gnc_gconf_toolbar_detachable

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

gnc_gconf_toolbar_detachable

Chris Shoemaker
I should really read the autotools manuals because I just don't get
them.  But before I do, does anybody know why I get the following
after a cvs up -dP, autogen and make clean?

-chris

Making all in test
make[2]: Entering directory `/home/chris/gnucash/gnucash/src/app-file/test'
/bin/sh ../../../libtool --mode=link gcc  -O0 -g -Wall -Wunused -Wmissing-prototypes -Wmissing-declarations   -Wdeclaration-after-statement  -g -o test-link  test-link.o ../libgncmod-app-file.la  -lpopt -lm  -lm
gcc -O0 -g -Wall -Wunused -Wmissing-prototypes -Wmissing-declarations -Wdeclaration-after-statement -g -o .libs/test-link test-link.o  ../.libs/libgncmod-app-file.so -L/usr/lib -L/usr/src/build/408073-i386/BUILD/guile-1.6.4/libguile/.libs /home/chris/gnucash/gnucash/src/gnome-utils/.libs/libgncmod-gnome-utils.so -L/usr/src/build/468104-i386/BUILD/guile-1.6.4/libguile/.libs /home/chris/gnucash/gnucash/src/network-utils/.libs/libgncmod-network-utils.so -L/usr/X11R6/lib -lgtkhtml-3.1 -lgnomeprintui-2-2 -lgnomeprint-2-2 -lglade-2.0 -lgsf-gnome-1 -lgsf-1 /home/chris/gnucash/gnucash/src/app-file/gnome/.libs/libgnc-app-file-gnome.so -lgnomeui-2 -lSM -lICE -lbonoboui-2 /usr/lib/libxml2.so -lz -lgnomecanvas-2 -lgnome-2 -lart_lgpl_2 -lpangoft2-1.0 -lbonobo-2 -lgnomevfs-2 -lbonobo-activation -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lpangoxft-1.0 -lpangox-1.0 -lpango-1.0 /home/chris/gnucash/gnucash/src/app-utils/.libs/libgncmod-app-utils.so /home/chris/gnucash/gnucash/src!
 /engine/.libs/libgncmod-engine.so /home/chris/gnucash/gnucash/src/engine/.libs/libgw-engine.so /home/chris/gnucash/gnucash/src/engine/.libs/libgw-kvp.so /home/chris/gnucash/gnucash/src/gnc-module/.libs/libgncmodule.so /home/chris/gnucash/gnucash/src/core-utils/.libs/libcore-utils.so -lgconf-2 -lORBit-2 -lgmodule-2.0 /usr/lib/libgwrap-wct.so /usr/lib/libgwrap-glib.so /usr/lib/libltdl.so /home/chris/gnucash/gnucash/src/calculation/.libs/libgncmod-calculation.so /usr/lib/libguile.so /usr/lib/libguile-ltdl.so -ldl /usr/lib/libqthreads.so -lpthread -lcrypt -lgthread-2.0 -lgobject-2.0 -lglib-2.0 /usr/lib/libpopt.so -lm -Wl,--rpath -Wl,/opt/gnucash-g2/lib/gnucash -Wl,--rpath -Wl,/opt/gnucash-g2/lib
/home/chris/gnucash/gnucash/src/gnome-utils/.libs/libgncmod-gnome-utils.so: undefined reference to `gnc_gconf_toolbar_detachable'
collect2: ld returned 1 exit status
make[2]: *** [test-link] Error 1

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: gnc_gconf_toolbar_detachable

David Hampton-2
On Thu, 2005-06-02 at 17:22 -0400, Chris Shoemaker wrote:

> I should really read the autotools manuals because I just don't get
> them.  But before I do, does anybody know why I get the following
> after a cvs up -dP, autogen and make clean?
>
> -chris
>
> Making all in test
> make[2]: Entering directory `/home/chris/gnucash/gnucash/src/app-file/test'
> /bin/sh ../../../libtool --mode=link gcc  -O0 -g -Wall -Wunused -Wmissing-prototypes -Wmissing-declarations   -Wdeclaration-after-statement  -g -o test-link  test-link.o ../libgncmod-app-file.la  -lpopt -lm  -lm
> gcc -O0 -g -Wall -Wunused -Wmissing-prototypes -Wmissing-declarations -Wdeclaration-after-statement -g -o .libs/test-link test-link.o  ../.libs/libgncmod-app-file.so -L/usr/lib -L/usr/src/build/408073-i386/BUILD/guile-1.6.4/libguile/.libs /home/chris/gnucash/gnucash/src/gnome-utils/.libs/libgncmod-gnome-utils.so -L/usr/src/build/468104-i386/BUILD/guile-1.6.4/libguile/.libs /home/chris/gnucash/gnucash/src/network-utils/.libs/libgncmod-network-utils.so -L/usr/X11R6/lib -lgtkhtml-3.1 -lgnomeprintui-2-2 -lgnomeprint-2-2 -lglade-2.0 -lgsf-gnome-1 -lgsf-1 /home/chris/gnucash/gnucash/src/app-file/gnome/.libs/libgnc-app-file-gnome.so -lgnomeui-2 -lSM -lICE -lbonoboui-2 /usr/lib/libxml2.so -lz -lgnomecanvas-2 -lgnome-2 -lart_lgpl_2 -lpangoft2-1.0 -lbonobo-2 -lgnomevfs-2 -lbonobo-activation -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lpangoxft-1.0 -lpangox-1.0 -lpango-1.0 /home/chris/gnucash/gnucash/src/app-utils/.libs/libgncmod-app-utils.so /home/chris/gnucash/gnucash/s!
 rc!
>  /engine/.libs/libgncmod-engine.so /home/chris/gnucash/gnucash/src/engine/.libs/libgw-engine.so /home/chris/gnucash/gnucash/src/engine/.libs/libgw-kvp.so /home/chris/gnucash/gnucash/src/gnc-module/.libs/libgncmodule.so /home/chris/gnucash/gnucash/src/core-utils/.libs/libcore-utils.so -lgconf-2 -lORBit-2 -lgmodule-2.0 /usr/lib/libgwrap-wct.so /usr/lib/libgwrap-glib.so /usr/lib/libltdl.so /home/chris/gnucash/gnucash/src/calculation/.libs/libgncmod-calculation.so /usr/lib/libguile.so /usr/lib/libguile-ltdl.so -ldl /usr/lib/libqthreads.so -lpthread -lcrypt -lgthread-2.0 -lgobject-2.0 -lglib-2.0 /usr/lib/libpopt.so -lm -Wl,--rpath -Wl,/opt/gnucash-g2/lib/gnucash -Wl,--rpath -Wl,/opt/gnucash-g2/lib
> /home/chris/gnucash/gnucash/src/gnome-utils/.libs/libgncmod-gnome-utils.so: undefined reference to `gnc_gconf_toolbar_detachable'
> collect2: ld returned 1 exit status
> make[2]: *** [test-link] Error 1

You've got an old generated file there somewhere.
gnc_gconf_toolbar_detachable() is now a static inline in a header file.
Try a 'make distclean'.

David


_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: gnc_gconf_toolbar_detachable

Chris Shoemaker
On Thu, Jun 02, 2005 at 05:31:45PM -0400, David Hampton wrote:

> On Thu, 2005-06-02 at 17:22 -0400, Chris Shoemaker wrote:
> > I should really read the autotools manuals because I just don't get
> > them.  But before I do, does anybody know why I get the following
> > after a cvs up -dP, autogen and make clean?
> >
> > -chris
> >
> > Making all in test
> > make[2]: Entering directory `/home/chris/gnucash/gnucash/src/app-file/test'
> > /bin/sh ../../../libtool --mode=link gcc  -O0 -g -Wall -Wunused -Wmissing-prototypes -Wmissing-declarations   -Wdeclaration-after-statement  -g -o test-link  test-link.o ../libgncmod-app-file.la  -lpopt -lm  -lm
> > gcc -O0 -g -Wall -Wunused -Wmissing-prototypes -Wmissing-declarations -Wdeclaration-after-statement -g -o .libs/test-link test-link.o  ../.libs/libgncmod-app-file.so -L/usr/lib -L/usr/src/build/408073-i386/BUILD/guile-1.6.4/libguile/.libs /home/chris/gnucash/gnucash/src/gnome-utils/.libs/libgncmod-gnome-utils.so -L/usr/src/build/468104-i386/BUILD/guile-1.6.4/libguile/.libs /home/chris/gnucash/gnucash/src/network-utils/.libs/libgncmod-network-utils.so -L/usr/X11R6/lib -lgtkhtml-3.1 -lgnomeprintui-2-2 -lgnomeprint-2-2 -lglade-2.0 -lgsf-gnome-1 -lgsf-1 /home/chris/gnucash/gnucash/src/app-file/gnome/.libs/libgnc-app-file-gnome.so -lgnomeui-2 -lSM -lICE -lbonoboui-2 /usr/lib/libxml2.so -lz -lgnomecanvas-2 -lgnome-2 -lart_lgpl_2 -lpangoft2-1.0 -lbonobo-2 -lgnomevfs-2 -lbonobo-activation -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lpangoxft-1.0 -lpangox-1.0 -lpango-1.0 /home/chris/gnucash/gnucash/src/app-utils/.libs/libgncmod-app-utils.so /home/chris/gnucash/gnucash!
 /src!
> >  /engine/.libs/libgncmod-engine.so /home/chris/gnucash/gnucash/src/engine/.libs/libgw-engine.so /home/chris/gnucash/gnucash/src/engine/.libs/libgw-kvp.so /home/chris/gnucash/gnucash/src/gnc-module/.libs/libgncmodule.so /home/chris/gnucash/gnucash/src/core-utils/.libs/libcore-utils.so -lgconf-2 -lORBit-2 -lgmodule-2.0 /usr/lib/libgwrap-wct.so /usr/lib/libgwrap-glib.so /usr/lib/libltdl.so /home/chris/gnucash/gnucash/src/calculation/.libs/libgncmod-calculation.so /usr/lib/libguile.so /usr/lib/libguile-ltdl.so -ldl /usr/lib/libqthreads.so -lpthread -lcrypt -lgthread-2.0 -lgobject-2.0 -lglib-2.0 /usr/lib/libpopt.so -lm -Wl,--rpath -Wl,/opt/gnucash-g2/lib/gnucash -Wl,--rpath -Wl,/opt/gnucash-g2/lib
> > /home/chris/gnucash/gnucash/src/gnome-utils/.libs/libgncmod-gnome-utils.so: undefined reference to `gnc_gconf_toolbar_detachable'
> > collect2: ld returned 1 exit status
> > make[2]: *** [test-link] Error 1
>
> You've got an old generated file there somewhere.
> gnc_gconf_toolbar_detachable() is now a static inline in a header file.
> Try a 'make distclean'.

Hmm, that didn't seem to make a difference.

[.libs]$ nm libgncmod-gnome-utils.so.0.0.0 |grep gconf_tool
         U gnc_gconf_toolbar_detachable

shows the undefined symbol.

It seems that the inline is not working quite right.

If it were truly inlined I wouldn't see it as an external symbol, right?

Maybe gnc-gconf-utils.h has to be added to the /core-utils/Makefile.am
somewhere?

Am I really the only person having this problem?  Anyone else building
g2 from yesterday's CVS?

-chris


_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: gnc_gconf_toolbar_detachable

Derek Atkins
Quoting Chris Shoemaker <[hidden email]>:

[snip]

> /home/chris/gnucash/gnucash/src/gnome-utils/.libs/libgncmod-gnome-utils.so:
> undefined reference to `gnc_gconf_toolbar_detachable'
> > > collect2: ld returned 1 exit status
> > > make[2]: *** [test-link] Error 1
> >
> > You've got an old generated file there somewhere.
> > gnc_gconf_toolbar_detachable() is now a static inline in a header file.
> > Try a 'make distclean'.
>
> Hmm, that didn't seem to make a difference.
>
> [.libs]$ nm libgncmod-gnome-utils.so.0.0.0 |grep gconf_tool
>          U gnc_gconf_toolbar_detachable
>
> shows the undefined symbol.
>
> It seems that the inline is not working quite right.
>
> If it were truly inlined I wouldn't see it as an external symbol, right?
>
> Maybe gnc-gconf-utils.h has to be added to the /core-utils/Makefile.am
> somewhere?
>
> Am I really the only person having this problem?  Anyone else building
> g2 from yesterday's CVS?

I just updated and built g2 branch about 30 minutes ago and it worked just fine
on my FC3 machine.

gcc version 3.4.3 20050227 (Red Hat 3.4.3-22.fc3)

-derek
--
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       [hidden email]                        PGP key available

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: gnc_gconf_toolbar_detachable

David Hampton-2
In reply to this post by Chris Shoemaker
On Fri, 2005-06-03 at 11:54 -0400, Chris Shoemaker wrote:

> Hmm, that didn't seem to make a difference.
>
> [.libs]$ nm libgncmod-gnome-utils.so.0.0.0 |grep gconf_tool
>          U gnc_gconf_toolbar_detachable
>
> shows the undefined symbol.
>
> It seems that the inline is not working quite right.
>
> If it were truly inlined I wouldn't see it as an external symbol, right?

Right.

> Maybe gnc-gconf-utils.h has to be added to the /core-utils/Makefile.am
> somewhere?
>
> Am I really the only person having this problem?  Anyone else building
> g2 from yesterday's CVS?

I checked out a new tree last night and compiled it with no problem at
all.  Even made some changed ans committed from it. :-)

David


_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: gnc_gconf_toolbar_detachable

Chris Shoemaker
In reply to this post by Derek Atkins
On Fri, Jun 03, 2005 at 11:58:54AM -0400, Derek Atkins wrote:

> Quoting Chris Shoemaker <[hidden email]>:
>
> [snip]
> > /home/chris/gnucash/gnucash/src/gnome-utils/.libs/libgncmod-gnome-utils.so:
> > undefined reference to `gnc_gconf_toolbar_detachable'
> > > > collect2: ld returned 1 exit status
> > > > make[2]: *** [test-link] Error 1
> > >
> > > You've got an old generated file there somewhere.
> > > gnc_gconf_toolbar_detachable() is now a static inline in a header file.
> > > Try a 'make distclean'.
> >
> > Hmm, that didn't seem to make a difference.
> >
> > [.libs]$ nm libgncmod-gnome-utils.so.0.0.0 |grep gconf_tool
> >          U gnc_gconf_toolbar_detachable
> >
> > shows the undefined symbol.
> >
> > It seems that the inline is not working quite right.
> >
> > If it were truly inlined I wouldn't see it as an external symbol, right?
> >
> > Maybe gnc-gconf-utils.h has to be added to the /core-utils/Makefile.am
> > somewhere?
> >
> > Am I really the only person having this problem?  Anyone else building
> > g2 from yesterday's CVS?
>
> I just updated and built g2 branch about 30 minutes ago and it worked just fine
> on my FC3 machine.
>
> gcc version 3.4.3 20050227 (Red Hat 3.4.3-22.fc3)

no kidding, so it's just me then. :(

I just re-updated cvs and autogen'd and make'd.  same failure.

I did recently add --enable-doxygen and --disable-error-on-warning to
my autogen line.  Let me remove them and retry...

-chris
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: gnc_gconf_toolbar_detachable

Chris Shoemaker
On Fri, Jun 03, 2005 at 12:19:55PM -0400, Chris Shoemaker wrote:
>
> no kidding, so it's just me then. :(
>
> I just re-updated cvs and autogen'd and make'd.  same failure.
>
> I did recently add --enable-doxygen and --disable-error-on-warning to
> my autogen line.  Let me remove them and retry...

dialog-utils.c: In function `gnc_restore_window_size':
dialog-utils.c:276: warning: implicit declaration of function `gnc_gconf_get_list'

almost like it's not correctly including gnc-gconf-utils.h

Oh darn.  I've got an old gnc-gconf-utils.h left over in gnome-utils.
make clean wouldn't remove it of course.  It got correctly removed in
the tree I cvs up -dP to, but then I copy to another tree, without
deleting removed files, because I often have extra files there I don't
want to delete.  User error.  I'm back on track now.  Thanks.

-chris
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: gnc_gconf_toolbar_detachable

Derek Atkins
Quoting Chris Shoemaker <[hidden email]>:

> On Fri, Jun 03, 2005 at 12:19:55PM -0400, Chris Shoemaker wrote:
> >
> > no kidding, so it's just me then. :(
> >
> > I just re-updated cvs and autogen'd and make'd.  same failure.
> >
> > I did recently add --enable-doxygen and --disable-error-on-warning to
> > my autogen line.  Let me remove them and retry...
>
> dialog-utils.c: In function `gnc_restore_window_size':
> dialog-utils.c:276: warning: implicit declaration of function
> `gnc_gconf_get_list'
>
> almost like it's not correctly including gnc-gconf-utils.h
>
> Oh darn.  I've got an old gnc-gconf-utils.h left over in gnome-utils.
> make clean wouldn't remove it of course.  It got correctly removed in
> the tree I cvs up -dP to, but then I copy to another tree, without
> deleting removed files, because I often have extra files there I don't
> want to delete.  User error.  I'm back on track now.  Thanks.

I'd suggest you use 'lndir' instead of 'cp -r' -- it fixes issues like these.  
The compiler will generally ignore dangling symlinks during the build.  The
downside is that you manually have to symlink "new" files, and you do need to
be careful to remove deleted .scm files...  But I find that this method works
okay for me.

It certainly makes it really easy to blow away a build and start from scratch
without having to bang on the cvs server.  :)

Glad you figured it out, tho.

> -chris

-derek

--
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       [hidden email]                        PGP key available

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: gnc_gconf_toolbar_detachable

David Hampton-2
In reply to this post by Chris Shoemaker
On Fri, 2005-06-03 at 12:19 -0400, Chris Shoemaker wrote:
> I did recently add --enable-doxygen and --disable-error-on-warning to
> my autogen line.  Let me remove them and retry...

Why would you want to turn off error-on-warning?

David


_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: gnc_gconf_toolbar_detachable

Dan Widyono
In reply to this post by Derek Atkins
> I'd suggest you use 'lndir' instead of 'cp -r' -- it fixes issues like these.  

Another option is "rsync -av --delete srcdir/ destdir/".  Bonus: destdir can
be desthost:destdir/ (so can srcdir of course).

Dan W.

> It certainly makes it really easy to blow away a build and start from scratch
> without having to bang on the cvs server.  :)

Amen.
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: gnc_gconf_toolbar_detachable

Chris Shoemaker
In reply to this post by David Hampton-2
On Fri, Jun 03, 2005 at 12:39:44PM -0400, David Hampton wrote:
> On Fri, 2005-06-03 at 12:19 -0400, Chris Shoemaker wrote:
> > I did recently add --enable-doxygen and --disable-error-on-warning to
> > my autogen line.  Let me remove them and retry...
>
> Why would you want to turn off error-on-warning?

Basically, I don't want my compile to fail when the warnings are from
-Wunused.  My old solution was to comment the Wunused out of the
configure.in file, but I thought this was cleaner.  Is there a better
way?

-chris
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: gnc_gconf_toolbar_detachable

Chris Shoemaker
In reply to this post by Derek Atkins
On Fri, Jun 03, 2005 at 12:39:20PM -0400, Derek Atkins wrote:

> I'd suggest you use 'lndir' instead of 'cp -r' -- it fixes issues like these.  

Nice.  I gave it a try.  I see how this handles removed files, and how
it's easy to start from scratch like this (and fast, too).

> The compiler will generally ignore dangling symlinks during the build.  The
> downside is that you manually have to symlink "new" files, and you do need to
> be careful to remove deleted .scm files...  But I find that this method works
> okay for me.

But I'm not sure I see the downside.  It seems that rerunning the lndir
command automatically adds links for added files.  And, as for the scm
files, what will break if there are broken links to scm files?  Let me
guess: the 'make install' will bomb trying to copy the broken .scm link?

I wonder how this will interact with 'quilt'.  I think I need some
efficient way to remove a single link and copy the file over just
before I make some edit.  Maybe an emacs hook...

-chris
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: gnc_gconf_toolbar_detachable

David Hampton-2
In reply to this post by Chris Shoemaker
On Fri, 2005-06-03 at 13:18 -0400, Chris Shoemaker wrote:

> On Fri, Jun 03, 2005 at 12:39:44PM -0400, David Hampton wrote:
> > On Fri, 2005-06-03 at 12:19 -0400, Chris Shoemaker wrote:
> > > I did recently add --enable-doxygen and --disable-error-on-warning to
> > > my autogen line.  Let me remove them and retry...
> >
> > Why would you want to turn off error-on-warning?
>
> Basically, I don't want my compile to fail when the warnings are from
> -Wunused.  My old solution was to comment the Wunused out of the
> configure.in file, but I thought this was cleaner.  Is there a better
> way?

You'll also miss any other warning message that gets lost in the
voluminous make output.  (Been there, done that.  Compilation ran to
completion, fired up gnucash and watched it die horribly, wondered why
the ^%$# the compiler didn't catch the problem, then discovered someone
had turned off -Werror.  Its happened to me more than once.)  If you're
just worried about unused declarations I'd stick with the configure.in
hack to remove -Wunused (or add -Wno-unused).

I'd appreciate it if you'd always do a final compile with -Werror
enabled before submitting patches, as that is the default for compiling
gnucash.  If not, anyone who tests your patch might get hit by the very
compile warnings you chose to ignore.

David


_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: gnc_gconf_toolbar_detachable

Chris Shoemaker
On Fri, Jun 03, 2005 at 02:03:16PM -0400, David Hampton wrote:

> On Fri, 2005-06-03 at 13:18 -0400, Chris Shoemaker wrote:
> > On Fri, Jun 03, 2005 at 12:39:44PM -0400, David Hampton wrote:
> > > On Fri, 2005-06-03 at 12:19 -0400, Chris Shoemaker wrote:
> > > > I did recently add --enable-doxygen and --disable-error-on-warning to
> > > > my autogen line.  Let me remove them and retry...
> > >
> > > Why would you want to turn off error-on-warning?
> >
> > Basically, I don't want my compile to fail when the warnings are from
> > -Wunused.  My old solution was to comment the Wunused out of the
> > configure.in file, but I thought this was cleaner.  Is there a better
> > way?
>
> You'll also miss any other warning message that gets lost in the
> voluminous make output.  (Been there, done that.  Compilation ran to
> completion, fired up gnucash and watched it die horribly, wondered why
> the ^%$# the compiler didn't catch the problem, then discovered someone
> had turned off -Werror.  Its happened to me more than once.)  If you're
> just worried about unused declarations I'd stick with the configure.in
> hack to remove -Wunused (or add -Wno-unused).

Ok.

>
> I'd appreciate it if you'd always do a final compile with -Werror
> enabled before submitting patches, as that is the default for compiling
> gnucash.  If not, anyone who tests your patch might get hit by the very
> compile warnings you chose to ignore.

Ok.

-chris
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: gnc_gconf_toolbar_detachable

Derek Atkins
In reply to this post by Chris Shoemaker
Chris Shoemaker <[hidden email]> writes:

> But I'm not sure I see the downside.  It seems that rerunning the lndir
> command automatically adds links for added files.  And, as for the scm
> files, what will break if there are broken links to scm files?  Let me
> guess: the 'make install' will bomb trying to copy the broken .scm link?

Actually, it's the building of the intl-scm.c that breaks when
you have dangling .scm symlinks.  The reason is that the code does:

  find . -name \*.scm | ...

And this will pick up the dangling symlink.  OOPS.

Feel free to send a patch to fix this strange case if you want,
but I've just lived with this myself for long enough that I don't
consider it a major issue.  The make bombs, I delete the .scm file,
and then it works.

-derek

--
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       [hidden email]                        PGP key available
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel