build system proposals for gnome2-branch

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

build system proposals for gnome2-branch

Christian Stimming
Hi all,

ok, now I've put together a proposal of what can be changed in the
gnome2-branch.  I'd suggest

- removal of acinclude.m4 -- it contains heaps of very old, legacy macros

- adding 2-3 unavoidable legacy macros into file macros/legacy_macros.m4
(attached)

- removal of ltmain.sh -- it should be installed by running libtoolize

- changing of macros/autogen.sh, diff attached.

The changes to autogen.sh are

- ACLOCAL_FLAGS="-I $GNOME2_PATH/share/aclocal $ACLOCAL_FLAGS"
+ # if GNOME2_PATH contains several directories, separate them properly
+ TMP_PATH=`echo $GNOME2_PATH | sed 's/:/ -I /g' `
+ ACLOCAL_FLAGS="-I $TMP_PATH/share/aclocal $ACLOCAL_FLAGS"

to tolerate env variable GNOME2_PATH=/opt/gnome:/usr/bla/bla, and then
commenting in the libtoolize calls. Oh, and most importantly fix one typo

-      macrosdir=`find . -name macros -print`
+      macrodirs=`find . -name macros -print`

If people agree, I would ask to apply this to gnucash-gnome2-dev. I don't have
time anymore and not for this week, so the end-test should be done by someone
else.

Regards,

Christian

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

buildsystem.diff (4K) Download Attachment
legacy_macros.m4 (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: build system proposals for gnome2-branch

Chris Shoemaker
On Wed, Jul 20, 2005 at 10:54:49PM +0200, Christian Stimming wrote:

> Hi all,
>
> ok, now I've put together a proposal of what can be changed in the
> gnome2-branch.  I'd suggest
>
> - removal of acinclude.m4 -- it contains heaps of very old, legacy macros
>
> - adding 2-3 unavoidable legacy macros into file macros/legacy_macros.m4
> (attached)
>
> - removal of ltmain.sh -- it should be installed by running libtoolize
>
> - changing of macros/autogen.sh, diff attached.
>
> The changes to autogen.sh are
>
> - ACLOCAL_FLAGS="-I $GNOME2_PATH/share/aclocal $ACLOCAL_FLAGS"
> + # if GNOME2_PATH contains several directories, separate them properly
> + TMP_PATH=`echo $GNOME2_PATH | sed 's/:/ -I /g' `
> + ACLOCAL_FLAGS="-I $TMP_PATH/share/aclocal $ACLOCAL_FLAGS"
>
> to tolerate env variable GNOME2_PATH=/opt/gnome:/usr/bla/bla, and then
> commenting in the libtoolize calls. Oh, and most importantly fix one typo
>
> -      macrosdir=`find . -name macros -print`
> +      macrodirs=`find . -name macros -print`
>
> If people agree, I would ask to apply this to gnucash-gnome2-dev. I don't have
> time anymore and not for this week, so the end-test should be done by someone
> else.

Well, I did volunteer, didn't I?  I'll see if I can test this tonight.

-chris

>
> Regards,
>
> Christian



> _______________________________________________
> gnucash-devel mailing list
> [hidden email]
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: build system proposals for gnome2-branch

Phil Longstaff-2
In reply to this post by Christian Stimming
On July 20, 2005 04:54 pm, Christian Stimming wrote:

> Hi all,
> - changing of macros/autogen.sh, diff attached.
>
> The changes to autogen.sh are
>
> - ACLOCAL_FLAGS="-I $GNOME2_PATH/share/aclocal $ACLOCAL_FLAGS"
> + # if GNOME2_PATH contains several directories, separate them properly
> + TMP_PATH=`echo $GNOME2_PATH | sed 's/:/ -I /g' `
> + ACLOCAL_FLAGS="-I $TMP_PATH/share/aclocal $ACLOCAL_FLAGS"
>
> to tolerate env variable GNOME2_PATH=/opt/gnome:/usr/bla/bla, and then
I would use:

-       ACLOCAL_FLAGS="-I $GNOME2_PATH/share/aclocal $ACLOCAL_FLAGS"
+       for dir in `echo $GNOME2_PATH | sed 's/:/ /g'`; do
+               ACLOCAL_FLAGS="-I $dir/share/aclocal $ACLOCAL_FLAGS"
+       done;

instead because each directory in GNOME2_PATH needs /share/aclocal added to
it.

Unified diff attached.

Phil

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

autogen.diff (621 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: build system proposals for gnome2-branch

Chris Shoemaker
In reply to this post by Chris Shoemaker
On Wed, Jul 20, 2005 at 05:08:08PM -0400, Chris Shoemaker wrote:

> On Wed, Jul 20, 2005 at 10:54:49PM +0200, Christian Stimming wrote:
> > Hi all,
> >
> > ok, now I've put together a proposal of what can be changed in the
> > gnome2-branch.  I'd suggest
> >
> > - removal of acinclude.m4 -- it contains heaps of very old, legacy macros
> >
> > - adding 2-3 unavoidable legacy macros into file macros/legacy_macros.m4
> > (attached)
> >
> > - removal of ltmain.sh -- it should be installed by running libtoolize
> >
> > - changing of macros/autogen.sh, diff attached.
> >
> > The changes to autogen.sh are
> >
> > - ACLOCAL_FLAGS="-I $GNOME2_PATH/share/aclocal $ACLOCAL_FLAGS"
> > + # if GNOME2_PATH contains several directories, separate them properly
> > + TMP_PATH=`echo $GNOME2_PATH | sed 's/:/ -I /g' `
> > + ACLOCAL_FLAGS="-I $TMP_PATH/share/aclocal $ACLOCAL_FLAGS"
> >
> > to tolerate env variable GNOME2_PATH=/opt/gnome:/usr/bla/bla, and then
> > commenting in the libtoolize calls. Oh, and most importantly fix one typo
> >
> > -      macrosdir=`find . -name macros -print`
> > +      macrodirs=`find . -name macros -print`
> >
> > If people agree, I would ask to apply this to gnucash-gnome2-dev. I don't have
> > time anymore and not for this week, so the end-test should be done by someone
> > else.
>
> Well, I did volunteer, didn't I?  I'll see if I can test this tonight.

Ok, I tested these changes and they pass the autogen/make/make
install/execute test.  I did notice a couple things.  I now see *many*
cases of:

*** Warning: Linking the shared library FOO.la against the loadable module
*** FOO.so is not portable!

Where FOO is just about every object in the tree.

Also, the 'make install' after a 'make' seemed to take longer than I'm
used to, but I may have imagined that.  Anyway, despite the warnings,
it runs.  I didn't test Phil's patch, which looks better, but I don't
have GNOME2_PATH set so I wouldn't have noticed.

Since it didn't break my build, I recommend this for commitment to g2,
with Phil's patch.  It'd be nice to squash those warnings, (along with
all the GOG CFLAGS warnings) but we can do that later.

-chris
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: build system proposals for gnome2-branch

Derek Atkins
Quoting Chris Shoemaker <[hidden email]>:

> Ok, I tested these changes and they pass the autogen/make/make
> install/execute test.  I did notice a couple things.  I now see *many*
> cases of:
>
> *** Warning: Linking the shared library FOO.la against the loadable module
> *** FOO.so is not portable!
>
> Where FOO is just about every object in the tree.

Yep, this is a known issue.  The half-assed modulatization effort conflated the
issue of Shared Library and Loadable Module.  So we're left with this crap.
Hopefully (after the g2 port, I suspect) we can fix the modularization.

> Also, the 'make install' after a 'make' seemed to take longer than I'm
> used to, but I may have imagined that.  Anyway, despite the warnings,
> it runs.  I didn't test Phil's patch, which looks better, but I don't
> have GNOME2_PATH set so I wouldn't have noticed.

I suspect this might be due to the "libtool relink" issue, where it wants to
relink all your libraries during "make install".  We had a workaround in our
version of ltmain.sh; it's possible your version does not.

> Since it didn't break my build, I recommend this for commitment to g2,
> with Phil's patch.  It'd be nice to squash those warnings, (along with
> all the GOG CFLAGS warnings) but we can do that later.

Thanks for testing.

-derek

--
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       [hidden email]                        PGP key available

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: build system proposals for gnome2-branch

Chris Shoemaker
On Wed, Jul 20, 2005 at 10:22:09PM -0400, Derek Atkins wrote:

> Quoting Chris Shoemaker <[hidden email]>:
>
> > Ok, I tested these changes and they pass the autogen/make/make
> > install/execute test.  I did notice a couple things.  I now see *many*
> > cases of:
> >
> > *** Warning: Linking the shared library FOO.la against the loadable module
> > *** FOO.so is not portable!
> >
> > Where FOO is just about every object in the tree.
>
> Yep, this is a known issue.  The half-assed modulatization effort conflated the
> issue of Shared Library and Loadable Module.  So we're left with this crap.
> Hopefully (after the g2 port, I suspect) we can fix the modularization.
>
> > Also, the 'make install' after a 'make' seemed to take longer than I'm
> > used to, but I may have imagined that.  Anyway, despite the warnings,
> > it runs.  I didn't test Phil's patch, which looks better, but I don't
> > have GNOME2_PATH set so I wouldn't have noticed.
>
> I suspect this might be due to the "libtool relink" issue, where it wants to
> relink all your libraries during "make install".  We had a workaround in our
> version of ltmain.sh; it's possible your version does not.

Yes, that is what it looks like.  Is the "libtool relink" issue
related to the modularization, too?

-chris

>
> > Since it didn't break my build, I recommend this for commitment to g2,
> > with Phil's patch.  It'd be nice to squash those warnings, (along with
> > all the GOG CFLAGS warnings) but we can do that later.
>
> Thanks for testing.
>
> -derek
>
> --
>        Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
>        Member, MIT Student Information Processing Board  (SIPB)
>        URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
>        [hidden email]                        PGP key available
>
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: build system proposals for gnome2-branch

Derek Atkins
Quoting Chris Shoemaker <[hidden email]>:

> > I suspect this might be due to the "libtool relink" issue, where it wants
> to
> > relink all your libraries during "make install".  We had a workaround in
> our
> > version of ltmain.sh; it's possible your version does not.
>
> Yes, that is what it looks like.  Is the "libtool relink" issue
> related to the modularization, too?

No.  Separate issues.

> -chris

-derek

--
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       [hidden email]                        PGP key available

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel