Re: [Gnucash-changes] Converting to GModule backends

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [Gnucash-changes] Converting to GModule backends

Chris Shoemaker
Neil,
        There are still many cases where your edits lines are indented
differently than the surrounding lines, e.g.:

On Thu, Oct 13, 2005 at 08:28:10AM -0400, Neil Williams wrote:

> @@ -129,15 +154,6 @@
>      closedir(xml2_dir);
>  
>      print_test_results();
> -    exit(get_rv());
> -}
> -
> -int
> -main (int argc, char ** argv)
> -{
> -  /*  getchar (); */
> -
> -  scm_boot_guile(argc, argv, guile_main, NULL);
> -
> + qof_close();
>    return 0;
>  }

        But, I noticed that some of your other edits are consistent.  Is
this coincidence or does it just mean that you fixed the problem for
new edits but still had old edits to commit?

-chris
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Gnucash-changes] Converting to GModule backends

Neil Williams-2
On Thursday 13 October 2005 2:16 pm, Chris Shoemaker wrote:
> Neil,
>         There are still many cases where your edits lines are indented
> differently than the surrounding lines, e.g.:

Many? I thought I'd caught them all - bar maybe one or two.

> On Thu, Oct 13, 2005 at 08:28:10AM -0400, Neil Williams wrote:

(leaving the filename in the snippet would be handy!)

> > @@ -129,15 +154,6 @@
> >      closedir(xml2_dir);
> >
> >      print_test_results();
> > + qof_close();

Yes, a "$!% tab.

>         But, I noticed that some of your other edits are consistent.  Is
> this coincidence or does it just mean that you fixed the problem for
> new edits but still had old edits to commit?

It means that I've:
1) Stopped my main IDE using tabs at all - it isn't able to show whitespace
and those editors that CAN show whitespace are the ones that have messed up
by changing the encoding and all manner of other hassles.
2) I've gone through the patch in vi which is fairly useful for this task as
although it doesn't highlight whitespace from tabs, it can adjust the tab
size making it easier to spot.

Why, after all this time, can't we all have editors that do the same thing? We
should be free to choose the editor that we prefer, but there's no standard
for things like this - it's really frustrating that each editor implements
whitespace and indenting in such different ways.

--

Neil Williams
=============
http://www.data-freedom.org/
http://www.nosoftwarepatents.com/
http://www.linux.codehelp.co.uk/


_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

attachment0 (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Gnucash-changes] Converting to GModule backends

Chris Shoemaker
On Thu, Oct 13, 2005 at 04:31:02PM +0100, Neil Williams wrote:

> On Thursday 13 October 2005 2:16 pm, Chris Shoemaker wrote:
> > Neil,
> >         There are still many cases where your edits lines are indented
> > differently than the surrounding lines, e.g.:
>
> Many? I thought I'd caught them all - bar maybe one or two.
>
> > On Thu, Oct 13, 2005 at 08:28:10AM -0400, Neil Williams wrote:
>
> (leaving the filename in the snippet would be handy!)
>
> > > @@ -129,15 +154,6 @@
> > >      closedir(xml2_dir);
> > >
> > >      print_test_results();
> > > + qof_close();
>
> Yes, a "$!% tab.
>
> >         But, I noticed that some of your other edits are consistent.  Is
> > this coincidence or does it just mean that you fixed the problem for
> > new edits but still had old edits to commit?
>
> It means that I've:
> 1) Stopped my main IDE using tabs at all - it isn't able to show whitespace
> and those editors that CAN show whitespace are the ones that have messed up
> by changing the encoding and all manner of other hassles.
> 2) I've gone through the patch in vi which is fairly useful for this task as
> although it doesn't highlight whitespace from tabs, it can adjust the tab
> size making it easier to spot.

Ok.  Thank you for addressing this.

>
> Why, after all this time, can't we all have editors that do the same thing? We
> should be free to choose the editor that we prefer, but there's no standard
> for things like this - it's really frustrating that each editor implements
> whitespace and indenting in such different ways.

Well, any decent editor meant for coding allows the user to define
this behavior.  And a rigorous project would enforce some style
guidelines.  Then it's just a matter of using settings that conform to
the guidelines for the project you're working on at the moment.

Yeah, it's a pain, but only the first time, like many such things.

-chris

p.s. BTW, I use emacs and it is a pure joy to use w.r.t. to this.
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Gnucash-changes] Converting to GModule backends

Derek Atkins
Chris Shoemaker <[hidden email]> writes:

> p.s. BTW, I use emacs and it is a pure joy to use w.r.t. to this.

I wonder if we should put the emacs magic in each file
to set our tab guidelines?

-derek
--
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       [hidden email]                        PGP key available
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Gnucash-changes] Converting to GModule backends

Chris Shoemaker
On Thu, Oct 13, 2005 at 01:16:52PM -0400, Derek Atkins wrote:
> Chris Shoemaker <[hidden email]> writes:
>
> > p.s. BTW, I use emacs and it is a pure joy to use w.r.t. to this.
>
> I wonder if we should put the emacs magic in each file
> to set our tab guidelines?

IMHO, that stuff is ugly, esp. for people not using emacs.  Anyway, I
see it as useful only if the style is intended to be different for
different files.  If not, then you don't need per-file settings.

-chris
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel