Re: [GNC-dev] gnucash maint: Multiple changes pushed

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] gnucash maint: Multiple changes pushed

Kevin Hale Boyes
The indentation (and logic) here:
https://github.com/Gnucash/gnucash/commit/3845611f#diff-ee628819286d2dd65d45baf2c5ef4bbdR454
suggests that the if applies to both indented lines but there are no braces
to form a block.

If gsr->reg is NULL then line line 456 will throw.

Kevin

On Sun, 9 Sep 2018 at 14:50, Geert Janssens <[hidden email]>
wrote:

> Updated  via  https://github.com/Gnucash/gnucash/commit/d069b67d (commit)
>          via  https://github.com/Gnucash/gnucash/commit/3634e8f5 (commit)
>          via  https://github.com/Gnucash/gnucash/commit/3845611f (commit)
>          via  https://github.com/Gnucash/gnucash/commit/4cc61463 (commit)
>         from  https://github.com/Gnucash/gnucash/commit/bfa6cd52 (commit)
>
>
>
> commit d069b67d48f99ef69d6a31c9dd428da67215b048
> Author: Geert Janssens <[hidden email]>
> Date:   Sun Sep 9 22:49:52 2018 +0200
>
>     Fix memory leak in xaccTransGetReadOnly
>
>     In addition implement a cache for this value as suggested in the
> comments
>     as this function is called on every transaction commit.
>
> commit 3634e8f59d576ce2c3b97fc6a817ada506d47989
> Author: Geert Janssens <[hidden email]>
> Date:   Sun Sep 9 17:43:05 2018 +0200
>
>     Fix memory leak using qof_instance_get on a GncGUID
>
>     The underlying boxed type will return a copy so we should free this
>     when no longer needed.
>
> commit 3845611f30848d6aca9b4764e24c050e801e0803
> Author: Geert Janssens <[hidden email]>
> Date:   Sun Sep 9 12:35:56 2018 +0200
>
>     Plug memory leak in register code
>
>     The table storing cell dimensions was never freed. The size of this
> table is
>     directly proportional to the number of cells in the register. So the
> more
>     transactions/splits in a register, the more memory was leaked - each
> time
>     a register was opened and closed. With my huge test book I saw leaks of
>     4Mb-10Mb per page that was opened/closed.
>
> commit 4cc61463abd60848e14543ec22adb8364b5a6cda
> Author: Geert Janssens <[hidden email]>
> Date:   Sun Sep 9 12:32:04 2018 +0200
>
>     Remove unused variable
>
>
>
> Summary of changes:
>  gnucash/gnome-utils/gnc-tree-util-split-reg.c      |  1 +
>  gnucash/gnome/dialog-payment.c                     |  1 +
>  gnucash/gnome/dialog-sx-editor.c                   |  1 +
>  gnucash/gnome/dialog-sx-editor2.c                  |  1 +
>  gnucash/gnome/gnc-plugin-page-register2.c          |  1 +
>  gnucash/gnome/gnc-split-reg.c                      | 22 ++++++----
>  gnucash/import-export/ofx/gnc-ofx-import.c         | 13 +++---
>  .../register/ledger-core/split-register-model.c    |  2 +-
>  gnucash/register/register-gnome/gnucash-sheet.c    | 14 ++++---
>  gnucash/register/register-gnome/gnucash-style.c    | 25 +++++++----
>  gnucash/register/register-gnome/gnucash-style.h    |  4 +-
>  libgnucash/app-utils/gnc-sx-instance-model.c       |  7 +++-
>  libgnucash/app-utils/gnc-ui-util.c                 |  7 +++-
>  libgnucash/core-utils/gnc-environment.c            |  7 ++--
>  libgnucash/engine/SX-book.c                        |  4 +-
>  libgnucash/engine/Transaction.c                    | 49
> ++++++++++++++++------
>  libgnucash/engine/Transaction.h                    |  2 +-
>  libgnucash/engine/TransactionP.h                   |  9 ++++
>  libgnucash/engine/cap-gains.c                      |  2 +
>  libgnucash/engine/gnc-budget.c                     |  5 ++-
>  libgnucash/engine/gncInvoice.c                     | 10 ++++-
>  libgnucash/engine/gncOwner.c                       |  2 +
>  libgnucash/engine/qofbook.cpp                      |  2 +-
>  libgnucash/engine/qofbook.h                        |  2 +-
>  .../engine/test/test-engine-kvp-properties.c       |  3 ++
>  25 files changed, 136 insertions(+), 60 deletions(-)
>
> _______________________________________________
> gnucash-patches mailing list
> [hidden email]
> https://lists.gnucash.org/mailman/listinfo/gnucash-patches
>
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] gnucash maint: Multiple changes pushed

Geert Janssens-4
Op zondag 9 september 2018 23:04:26 CEST schreef Kevin Hale Boyes:
> The indentation (and logic) here:
> https://github.com/Gnucash/gnucash/commit/3845611f#diff-ee628819286d2dd65d45
> baf2c5ef4bbdR454 suggests that the if applies to both indented lines but
> there are no braces to form a block.
>
> If gsr->reg is NULL then line line 456 will throw.
>
> Kevin
>
Oops, good catch.

Fixed and thanks!

Geert


_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel