Re: [GNC-dev] gnucash maint: Fix missing leading dot in sheet specification.

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] gnucash maint: Fix missing leading dot in sheet specification.

Geert Janssens-4
The . is only required for gtk3 less than 3.20. Before that version gtk doesn't understand widget names. So for compatibility Bob added classes. That workaround will eventually go away.

Perhaps we should mention both in the css file with a comment or provide two sample css files. I *thought* we had two even.

Regards,
Geert

John Ralls <[hidden email]> schreef op 10 juli 2018 16:12:35 CEST:

>Updated via  https://github.com/Gnucash/gnucash/commit/e6ea84ba
>(commit)
> from  https://github.com/Gnucash/gnucash/commit/38748f20 (commit)
>
>
>
>commit e6ea84ba5830b38121aa927d4373f956b9accfa2
>Author: John Ralls <[hidden email]>
>Date:   Tue Jul 10 07:12:21 2018 -0700
>
>    Fix missing leading dot in sheet specification.
>
>
>
>Summary of changes:
> doc/gtk-3.0.css | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>_______________________________________________
>gnucash-patches mailing list
>[hidden email]
>https://lists.gnucash.org/mailman/listinfo/gnucash-patches

Sent from my smartphone. Please excuse my brevity.
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] gnucash maint: Fix missing leading dot in sheet specification.

John Ralls-2
But gtk 3.20+ accepts the . so for simplicity I suggest that the example should keep it. Perhaps we could add a comment in it saying that it's optional for gtk+-3.20.0 and later.

Regards,
John Ralls


> On Jul 10, 2018, at 12:27 PM, Geert Janssens <[hidden email]> wrote:
>
> The . is only required for gtk3 less than 3.20. Before that version gtk doesn't understand widget names. So for compatibility Bob added classes. That workaround will eventually go away.
>
> Perhaps we should mention both in the css file with a comment or provide two sample css files. I *thought* we had two even.
>
> Regards,
> Geert
>
> John Ralls <[hidden email]> schreef op 10 juli 2018 16:12:35 CEST:
>> Updated via  https://github.com/Gnucash/gnucash/commit/e6ea84ba
>> (commit)
>> from  https://github.com/Gnucash/gnucash/commit/38748f20 (commit)
>>
>>
>>
>> commit e6ea84ba5830b38121aa927d4373f956b9accfa2
>> Author: John Ralls <[hidden email]>
>> Date:   Tue Jul 10 07:12:21 2018 -0700
>>
>>   Fix missing leading dot in sheet specification.
>>
>>
>>
>> Summary of changes:
>> doc/gtk-3.0.css | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> _______________________________________________
>> gnucash-patches mailing list
>> [hidden email]
>> https://lists.gnucash.org/mailman/listinfo/gnucash-patches
>
> Sent from my smartphone. Please excuse my brevity.
> _______________________________________________
> gnucash-devel mailing list
> [hidden email]
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel