Re: [GNC-dev] gnucash maint: Bug 795080 - Some dates reset to 01/01/1970

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] gnucash maint: Bug 795080 - Some dates reset to 01/01/1970

Geert Janssens-4
Op vrijdag 2 november 2018 18:45:52 CET schreef John Ralls:

> Updated via  https://github.com/Gnucash/gnucash/commit/0e723610 (commit)
> from  https://github.com/Gnucash/gnucash/commit/19b3643a (commit)
>
>
>
> commit 0e723610f0cb23515f564bc87e6b0b2f16577f5b
> Author: John Ralls <[hidden email]>
> Date:   Fri Nov 2 10:29:52 2018 -0700
>
>     Bug 795080 - Some dates reset to 01/01/1970
>
>     The first fix for this bug handled structs tm with ambiguous times.
>     This one fixes the GncDate constructor when the time is ambiguous
>     because it's in the DST-change hour, using the same add 3 hours,
>     construct the LDT, and subtract the 3 hours from the result.
>
>     The string constructor handles only simple-offset HH:MM timezones and so
> is immune to the bug.
>
> --- a/po/POTFILES.in
> +++ b/po/POTFILES.in
> @@ -616,6 +616,7 @@ libgnucash/core-utils/gnc-locale-utils.c
>  libgnucash/core-utils/gnc-path.c
>  libgnucash/core-utils/gnc-prefs.c
>  libgnucash/doc/doxygen_main_page.c
> +libgnucash/engine/.#gnc-datetime.cpp

What is this file and does it have translatable strings ? Or did an editor's
swap file sneak in here ?

Geert


_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] gnucash maint: Bug 795080 - Some dates reset to 01/01/1970

John Ralls-2


> On Nov 2, 2018, at 11:10 AM, Geert Janssens <[hidden email]> wrote:
>
> Op vrijdag 2 november 2018 18:45:52 CET schreef John Ralls:
>> Updated via  https://github.com/Gnucash/gnucash/commit/0e723610 (commit)
>> from  https://github.com/Gnucash/gnucash/commit/19b3643a (commit)
>>
>>
>>
>> commit 0e723610f0cb23515f564bc87e6b0b2f16577f5b
>> Author: John Ralls <[hidden email]>
>> Date:   Fri Nov 2 10:29:52 2018 -0700
>>
>>    Bug 795080 - Some dates reset to 01/01/1970
>>
>>    The first fix for this bug handled structs tm with ambiguous times.
>>    This one fixes the GncDate constructor when the time is ambiguous
>>    because it's in the DST-change hour, using the same add 3 hours,
>>    construct the LDT, and subtract the 3 hours from the result.
>>
>>    The string constructor handles only simple-offset HH:MM timezones and so
>> is immune to the bug.
>>
>> --- a/po/POTFILES.in
>> +++ b/po/POTFILES.in
>> @@ -616,6 +616,7 @@ libgnucash/core-utils/gnc-locale-utils.c
>> libgnucash/core-utils/gnc-path.c
>> libgnucash/core-utils/gnc-prefs.c
>> libgnucash/doc/doxygen_main_page.c
>> +libgnucash/engine/.#gnc-datetime.cpp
>
> What is this file and does it have translatable strings ? Or did an editor's
> swap file sneak in here ?

That's an emacs artifact of some sort. It seems to be a symlink that exists when there are unsaved changes in the file.

I've removed it from POTFILES.in, but what are we doing wrong in building it that it's picking up hidden files?

Regards,
John Ralls

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] gnucash maint: Bug 795080 - Some dates reset to 01/01/1970

Geert Janssens-4
Op vrijdag 2 november 2018 19:28:40 CET schreef John Ralls:

> > On Nov 2, 2018, at 11:10 AM, Geert Janssens <[hidden email]>
> > wrote:>
> > Op vrijdag 2 november 2018 18:45:52 CET schreef John Ralls:
> >> --- a/po/POTFILES.in
> >> +++ b/po/POTFILES.in
> >> @@ -616,6 +616,7 @@ libgnucash/core-utils/gnc-locale-utils.c
> >> libgnucash/core-utils/gnc-path.c
> >> libgnucash/core-utils/gnc-prefs.c
> >> libgnucash/doc/doxygen_main_page.c
> >> +libgnucash/engine/.#gnc-datetime.cpp
> >
> > What is this file and does it have translatable strings ? Or did an
> > editor's swap file sneak in here ?
>
> That's an emacs artifact of some sort. It seems to be a symlink that exists
> when there are unsaved changes in the file.
>
> I've removed it from POTFILES.in, but what are we doing wrong in building it
> that it's picking up hidden files?

I have updated the POTFILES.in generation code to skip hidden files.

Geert


_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] gnucash maint: Bug 795080 - Some dates reset to 01/01/1970

John Ralls


> On Nov 7, 2018, at 5:41 AM, Geert Janssens <[hidden email]> wrote:
>
> Op vrijdag 2 november 2018 19:28:40 CET schreef John Ralls:
>>> On Nov 2, 2018, at 11:10 AM, Geert Janssens <[hidden email]>
>>> wrote:>
>>> Op vrijdag 2 november 2018 18:45:52 CET schreef John Ralls:
>>>> --- a/po/POTFILES.in
>>>> +++ b/po/POTFILES.in
>>>> @@ -616,6 +616,7 @@ libgnucash/core-utils/gnc-locale-utils.c
>>>> libgnucash/core-utils/gnc-path.c
>>>> libgnucash/core-utils/gnc-prefs.c
>>>> libgnucash/doc/doxygen_main_page.c
>>>> +libgnucash/engine/.#gnc-datetime.cpp
>>>
>>> What is this file and does it have translatable strings ? Or did an
>>> editor's swap file sneak in here ?
>>
>> That's an emacs artifact of some sort. It seems to be a symlink that exists
>> when there are unsaved changes in the file.
>>
>> I've removed it from POTFILES.in, but what are we doing wrong in building it
>> that it's picking up hidden files?
>
> I have updated the POTFILES.in generation code to skip hidden files.

Thanks.

Regards,
John Ralls

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel