GnuCash wont build anymore (From SVN)

classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

GnuCash wont build anymore (From SVN)

Tor Harald Thorland
Hi,

I have successfully built the 1.9 release from SVN 6-7 times now, but
today it failed after i updated it.

I even removed the whole directory and did "download" all of it again.

I ran the following commands:
svn co http://svn.gnucash.org/repo/gnucash/trunk gnucash
cd gnucash
./autogen.sh --enable-debug --prefix=/opt/gnucash-1.9
./configure --enable-error-on-warning --enable-compile-warnings
--enable-debug --prefix=/opt/gnucash-1.9
make

When I run the make ill get the following output

sing-declarations -Werror -Wdeclaration-after-statement
-Wno-pointer-sign -MT gnc-splash.lo -MD -MP -MF .deps/gnc-splash.Tpo -c
gnc-splash.c  -fPIC -DPIC -o .libs/gnc-splash.o
gnc-splash.c: In function 'gnc_show_splash_screen':
gnc-splash.c:78: error: syntax error before ',' token
make[5]: *** [gnc-splash.lo] Error 1
make[5]: Leaving directory `/home/tortho/SVN/gnucash/src/gnome-utils'
make[4]: *** [all-recursive] Error 1
make[4]: Leaving directory `/home/tortho/SVN/gnucash/src/gnome-utils'
make[3]: *** [all] Error 2
make[3]: Leaving directory `/home/tortho/SVN/gnucash/src/gnome-utils'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/tortho/SVN/gnucash/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/tortho/SVN/gnucash'
make: *** [all] Error 2


Any suggestions?

Tor Harald
_______________________________________________
gnucash-user mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-user
Reply | Threaded
Open this post in threaded view
|

Re: GnuCash wont build anymore (From SVN)

Derek Atkins
Quoting Tor Harald Thorland <[hidden email]>:

> When I run the make ill get the following output
>
> sing-declarations -Werror -Wdeclaration-after-statement
> -Wno-pointer-sign -MT gnc-splash.lo -MD -MP -MF .deps/gnc-splash.Tpo -c
> gnc-splash.c  -fPIC -DPIC -o .libs/gnc-splash.o
> gnc-splash.c: In function 'gnc_show_splash_screen':
> gnc-splash.c:78: error: syntax error before ',' token
> make[5]: *** [gnc-splash.lo] Error 1
> make[5]: Leaving directory `/home/tortho/SVN/gnucash/src/gnome-utils'

I cannot reproduce this issue here.  I just pulled down current SVN
and it's building just fine for me.  What do you get from:

  cat src/gnome-utils/gnc-version.h
  cat src/gnome-utils/gnc-svninfo.h

> Any suggestions?

Not particularly..  It's working for me.

-derek

--
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       [hidden email]                        PGP key available

_______________________________________________
gnucash-user mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-user
Reply | Threaded
Open this post in threaded view
|

Re: GnuCash wont build anymore (From SVN)

Tor Harald Thorland
Derek Atkins wrote:

> Quoting Tor Harald Thorland <[hidden email]>:
>
>> When I run the make ill get the following output
>>
>> sing-declarations -Werror -Wdeclaration-after-statement
>> -Wno-pointer-sign -MT gnc-splash.lo -MD -MP -MF .deps/gnc-splash.Tpo -c
>> gnc-splash.c  -fPIC -DPIC -o .libs/gnc-splash.o
>> gnc-splash.c: In function 'gnc_show_splash_screen':
>> gnc-splash.c:78: error: syntax error before ',' token
>> make[5]: *** [gnc-splash.lo] Error 1
>> make[5]: Leaving directory `/home/tortho/SVN/gnucash/src/gnome-utils'
>
>
> I cannot reproduce this issue here.  I just pulled down current SVN
> and it's building just fine for me.  What do you get from:
>
>  cat src/gnome-utils/gnc-version.h
>  cat src/gnome-utils/gnc-svninfo.h

tortho@inspiron:~/SVN/gnucash$ cat src/gnome-utils/gnc-version.h
/* Autogenerated. Do not change. */
#ifndef GNC_VERSION_H
#define GNC_VERSION_H

#define GNUCASH_SVN 1
#define GNUCASH_BUILD_DATE "2005-11-21"
#include "gnc-svninfo.h"
#endif
tortho@inspiron:~/SVN/gnucash$ cat src/gnome-utils/gnc-svninfo.h
#define GNUCASH_SVN_REV
tortho@inspiron:~/SVN/gnucash$


That was the output. The strange thing is that I have builded this
several times now, but today it failed without me doing any changes on
my system...

Tor Harald
_______________________________________________
gnucash-user mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-user
Reply | Threaded
Open this post in threaded view
|

Re: GnuCash wont build anymore (From SVN)

Derrick Hudson
In reply to this post by Tor Harald Thorland
On Mon, Nov 21, 2005 at 09:31:27PM +0100, Tor Harald Thorland wrote:
| Hi,
|
| I have successfully built the 1.9 release from SVN 6-7 times now, but
| today it failed after i updated it.
[...]
| When I run the make ill get the following output
|
| sing-declarations -Werror -Wdeclaration-after-statement
| -Wno-pointer-sign -MT gnc-splash.lo -MD -MP -MF .deps/gnc-splash.Tpo -c
| gnc-splash.c  -fPIC -DPIC -o .libs/gnc-splash.o
| gnc-splash.c: In function 'gnc_show_splash_screen':
| gnc-splash.c:78: error: syntax error before ',' token

| Any suggestions?

Check out line 78 of gnc-splash.c and fix the syntax error :-).


I just took a quick look here and don't see anything obviously wrong.
You can see using 'svn log src/gnome-utils/gnc-splash.c' that that
file was changed on 2005-11-19 18:53:34 -0500.  It is possible that
either an error was introduced (maybe one that doesn't affect that
developer's machine).  Further investigation would be needed, either
on your system or if someone else can reproduce it.  (it doesn't
configure for me right now because my libgsf is too new)

-D

--
There is not a righteous man on earth
    who does what is right and never sins.
        Ecclesiastes 7:20
 
www: http://dman13.dyndns.org/~dman/            jabber: [hidden email]

_______________________________________________
gnucash-user mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-user

signature.asc (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: GnuCash wont build anymore (From SVN)

Derek Atkins
In reply to this post by Tor Harald Thorland
Quoting Tor Harald Thorland <[hidden email]>:

> tortho@inspiron:~/SVN/gnucash$ cat src/gnome-utils/gnc-version.h
> /* Autogenerated. Do not change. */
> #ifndef GNC_VERSION_H
> #define GNC_VERSION_H
>
> #define GNUCASH_SVN 1
> #define GNUCASH_BUILD_DATE "2005-11-21"
> #include "gnc-svninfo.h"
> #endif

Okay, so gnc-version is correct.  Not at all surprising..  But...

> tortho@inspiron:~/SVN/gnucash$ cat src/gnome-utils/gnc-svninfo.h
> #define GNUCASH_SVN_REV
> tortho@inspiron:~/SVN/gnucash$

This is broken.  How.. odd.  It's worked for me in all tests that I've
tried.  This seems to imply that this section of Makefile isn't working
correctly:

gnc-svninfo.h: .gnc-svninfo.h
        @s=${srcdir} ; \
        if [ -h ${srcdir}/Makefile.am ] ; then \
                d=`readlink $(srcdir)/Makefile.am` ; \
                s="${srcdir}/`dirname $$d`" ; \
        fi ; \
        if [ -d $$s/.svn ] ; then \
                svninfo=`svn info $$s |grep '^Revision: '|sed 's/Revision: //'` ; \
                echo "#define GNUCASH_SVN_REV $$svninfo" > gnc-svninfo.h ; \
        fi

Well, another potential issue would be if you don't have "svn" in
your PATH when you're building gnucash.  But I don't see why that
would change this time versus previous builds.  And you said it worked
before.

So..  Umm..  How about this.  In src/gnome-utils/Makefile.am, find the
code I just copied above and remove the @.  Then do:

  make -C src/gnome-utils gnc-svninfo.h

> That was the output. The strange thing is that I have builded this
> several times now, but today it failed without me doing any changes on
> my system...

Well, obviously SOMETHING changed..  If it worked before but now it
doesn't, then clearly SOMETHING is different.  It's just a question
of what changed.

-derek

--
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       [hidden email]                        PGP key available

_______________________________________________
gnucash-user mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-user
Reply | Threaded
Open this post in threaded view
|

Re: GnuCash wont build anymore (From SVN)

Tor Harald Thorland
In reply to this post by Derrick Hudson
Derrick Hudson wrote:

>On Mon, Nov 21, 2005 at 09:31:27PM +0100, Tor Harald Thorland wrote:
>| Hi,
>|
>| I have successfully built the 1.9 release from SVN 6-7 times now, but
>| today it failed after i updated it.
>[...]
>| When I run the make ill get the following output
>|
>| sing-declarations -Werror -Wdeclaration-after-statement
>| -Wno-pointer-sign -MT gnc-splash.lo -MD -MP -MF .deps/gnc-splash.Tpo -c
>| gnc-splash.c  -fPIC -DPIC -o .libs/gnc-splash.o
>| gnc-splash.c: In function 'gnc_show_splash_screen':
>| gnc-splash.c:78: error: syntax error before ',' token
>
>| Any suggestions?
>
>Check out line 78 of gnc-splash.c and fix the syntax error :-).
>
>
>I just took a quick look here and don't see anything obviously wrong.
>You can see using 'svn log src/gnome-utils/gnc-splash.c' that that
>file was changed on 2005-11-19 18:53:34 -0500.  It is possible that
>either an error was introduced (maybe one that doesn't affect that
>developer's machine).  Further investigation would be needed, either
>on your system or if someone else can reproduce it.  (it doesn't
>configure for me right now because my libgsf is too new)
>
>-D
>
>  
>
I found the piece that made the trouble:

I edited the gnc-splash.c file, and then the make worked perfectly.
I'm not a programmer, and cant figure out anything else, except someone
instruct me to.

File BEFORE edit:

#ifdef GNUCASH_SVN
  ver_string = g_strdup_printf(_("Version: Gnucash-%s svn (r%d built %s)")
                , VERSION, GNUCASH_SVN_REV, GNUCASH_BUILD_DATE);
#else
  ver_string = g_strdup_printf(_("Version: Gnucash-%s"), VERSION);
#endif

File AFTER edit:

#ifdef GNUCASH_SVN
  ver_string = g_strdup_printf(_("Version: Gnucash-%s svn (r built %s)")
                , VERSION, GNUCASH_BUILD_DATE);
#else
  ver_string = g_strdup_printf(_("Version: Gnucash-%s"), VERSION);
#endif


So, I removed the: GNUCASH_SVN_REV, and the corresponding %d

Tor Harald Thorland
_______________________________________________
gnucash-user mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-user
Reply | Threaded
Open this post in threaded view
|

Re: GnuCash wont build anymore (From SVN)

Derek Atkins
Quoting Tor Harald Thorland <[hidden email]>:

> I found the piece that made the trouble:
>
> I edited the gnc-splash.c file, and then the make worked perfectly.
> I'm not a programmer, and cant figure out anything else, except someone
> instruct me to.
>
> File BEFORE edit:
>
> #ifdef GNUCASH_SVN
>  ver_string = g_strdup_printf(_("Version: Gnucash-%s svn (r%d built %s)")
>                , VERSION, GNUCASH_SVN_REV, GNUCASH_BUILD_DATE);
> #else
>  ver_string = g_strdup_printf(_("Version: Gnucash-%s"), VERSION);
> #endif
>
> File AFTER edit:
>
> #ifdef GNUCASH_SVN
>  ver_string = g_strdup_printf(_("Version: Gnucash-%s svn (r built %s)")
>                , VERSION, GNUCASH_BUILD_DATE);
> #else
>  ver_string = g_strdup_printf(_("Version: Gnucash-%s"), VERSION);
> #endif
>
>
> So, I removed the: GNUCASH_SVN_REV, and the corresponding %d

You fixed the symptom but not the cause..  The cause, which you should
still try to track down (because this patch will not go into SVN) is
to figure out why the gnc-svninfo.h file isn't being generated
properly.

Figure /THAT/ out and then we can talk.

> Tor Harald Thorland

-derek

--
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       [hidden email]                        PGP key available

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: GnuCash wont build anymore (From SVN)

Tor Harald Thorland
Derek Atkins wrote:

> Quoting Tor Harald Thorland <[hidden email]>:
>
>> I found the piece that made the trouble:
>>
>> I edited the gnc-splash.c file, and then the make worked perfectly.
>> I'm not a programmer, and cant figure out anything else, except someone
>> instruct me to.
>>
>> File BEFORE edit:
>>
>> #ifdef GNUCASH_SVN
>>  ver_string = g_strdup_printf(_("Version: Gnucash-%s svn (r%d built
>> %s)")
>>                , VERSION, GNUCASH_SVN_REV, GNUCASH_BUILD_DATE);
>> #else
>>  ver_string = g_strdup_printf(_("Version: Gnucash-%s"), VERSION);
>> #endif
>>
>> File AFTER edit:
>>
>> #ifdef GNUCASH_SVN
>>  ver_string = g_strdup_printf(_("Version: Gnucash-%s svn (r built %s)")
>>                , VERSION, GNUCASH_BUILD_DATE);
>> #else
>>  ver_string = g_strdup_printf(_("Version: Gnucash-%s"), VERSION);
>> #endif
>>
>>
>> So, I removed the: GNUCASH_SVN_REV, and the corresponding %d
>
>
> You fixed the symptom but not the cause..  The cause, which you should
> still try to track down (because this patch will not go into SVN) is
> to figure out why the gnc-svninfo.h file isn't being generated
> properly.
>
> Figure /THAT/ out and then we can talk.

As I said, I'm NOT a programmer, but what should the version definition
look like?
The thing here is that my last build was befor the following thing was
changed.

You can see using 'svn log src/gnome-utils/gnc-splash.c' that that
file was changed on 2005-11-19 18:53:34 -0500.



Does this output look correct?

tortho@inspiron:~/SVN/gnucash$ svninfo=`svn info $$s |grep '^Revision:
'|sed 's/Revision: //'` ;
tortho@inspiron:~/SVN/gnucash$ echo "#define GNUCASH_SVN_REV $$svninfo"
#define GNUCASH_SVN_REV 17734svninfo
tortho@inspiron:~/SVN/gnucash$


Tor Harald
_______________________________________________
gnucash-user mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-user
Reply | Threaded
Open this post in threaded view
|

Re: GnuCash wont build anymore (From SVN)

Derek Atkins
In reply to this post by Derrick Hudson
Derrick Hudson <[hidden email]> writes:

> On Mon, Nov 21, 2005 at 09:31:27PM +0100, Tor Harald Thorland wrote:
> | Hi,
> |
> | I have successfully built the 1.9 release from SVN 6-7 times now, but
> | today it failed after i updated it.
> [...]
> | When I run the make ill get the following output
> |
> | sing-declarations -Werror -Wdeclaration-after-statement
> | -Wno-pointer-sign -MT gnc-splash.lo -MD -MP -MF .deps/gnc-splash.Tpo -c
> | gnc-splash.c  -fPIC -DPIC -o .libs/gnc-splash.o
> | gnc-splash.c: In function 'gnc_show_splash_screen':
> | gnc-splash.c:78: error: syntax error before ',' token
>
> | Any suggestions?
>
> Check out line 78 of gnc-splash.c and fix the syntax error :-).

BZZT.  Try again.

> I just took a quick look here and don't see anything obviously wrong.
> You can see using 'svn log src/gnome-utils/gnc-splash.c' that that
> file was changed on 2005-11-19 18:53:34 -0500.  It is possible that
> either an error was introduced (maybe one that doesn't affect that
> developer's machine).  Further investigation would be needed, either
> on your system or if someone else can reproduce it.  (it doesn't
> configure for me right now because my libgsf is too new)

That's because there IS nothing wrong with gnc-splash.c.  The
problem is in gnc-svninfo.h.

-derek

--
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       [hidden email]                        PGP key available
_______________________________________________
gnucash-user mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-user
Reply | Threaded
Open this post in threaded view
|

Re: GnuCash wont build anymore (From SVN)

Derek Atkins
In reply to this post by Tor Harald Thorland
Quoting Tor Harald Thorland <[hidden email]>:

> As I said, I'm NOT a programmer, but what should the version definition
> look like?

If should be a number.

> The thing here is that my last build was befor the following thing was
> changed.

Yes.  From "svn log gnc-splash.c":

r11981 | hampton | 2005-11-19 18:53:34 -0500 (Sat, 19 Nov 2005) | 5 lines

Include file cleanup.  Remove the messages.[ch] files in favor of the
glib supplied gi18n.h file.  Replace includes of gnome.h with gtk.h
(or better yet glib.h) wherever possible.  Don't include gnome.h from
any header files.  Remove some extraneous includes.

------------------------------------------------------------------------
r11964 | hampton | 2005-11-17 00:35:02 -0500 (Thu, 17 Nov 2005) | 1 line

Update FSF street address.
------------------------------------------------------------------------
r11789 | hampton | 2005-11-02 15:32:42 -0500 (Wed, 02 Nov 2005) | 3 lines

Use a dynamically allocated string for the version.


The change that was made between 11964 and 11981 is this diff:

--- gnc-splash.c        (revision 11964)
+++ gnc-splash.c        (working copy)
@@ -22,7 +22,8 @@

#include "config.h"

-#include <gnome.h>
+#include <gtk/gtk.h>
+#include <glib/gi18n.h>

#include "gnc-gnome-utils.h"
#include "gnc-splash.h"

That change wont have affected this.  Sorry.  No, the problem is /still/
not gnc-splash.c -- the problem is the generation of gnc-svninfo.h.  But
then again I said that already but you don't seem to believe me.

> You can see using 'svn log src/gnome-utils/gnc-splash.c' that that
> file was changed on 2005-11-19 18:53:34 -0500.

Yes. see above.  it's an irrelevant change.

> Does this output look correct?
>
> tortho@inspiron:~/SVN/gnucash$ svninfo=`svn info $$s |grep '^Revision:
> '|sed 's/Revision: //'` ;
> tortho@inspiron:~/SVN/gnucash$ echo "#define GNUCASH_SVN_REV $$svninfo"
> #define GNUCASH_SVN_REV 17734svninfo
> tortho@inspiron:~/SVN/gnucash$

No -- But what I handed you was a Makefile snippet and you're running
it under the shell.  So I'm not surprised it doesn't look right.  Try
running the following from your build directory src/gnome-utils:

  svn info . | grep '^Revision: ' | sed 's/Revision: //'

> Tor Harald

-derek

--
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       [hidden email]                        PGP key available

_______________________________________________
gnucash-user mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-user
Reply | Threaded
Open this post in threaded view
|

Re: GnuCash wont build anymore (From SVN)

Derek Atkins
FYI,

I've just committed a patch to SVN that should cause the build
to fail during the generation of gnc-svninfo if the "svn info"
fails..   So could you "svn update" and rebuild and tell me what
it does?

Thanks,

-derek

Quoting Derek Atkins <[hidden email]>:

> Quoting Tor Harald Thorland <[hidden email]>:
>
>> As I said, I'm NOT a programmer, but what should the version definition
>> look like?
>
> If should be a number.
>
>> The thing here is that my last build was befor the following thing was
>> changed.
>
> Yes.  From "svn log gnc-splash.c":
>
> r11981 | hampton | 2005-11-19 18:53:34 -0500 (Sat, 19 Nov 2005) | 5 lines
>
> Include file cleanup.  Remove the messages.[ch] files in favor of the
> glib supplied gi18n.h file.  Replace includes of gnome.h with gtk.h
> (or better yet glib.h) wherever possible.  Don't include gnome.h from
> any header files.  Remove some extraneous includes.
>
> ------------------------------------------------------------------------
> r11964 | hampton | 2005-11-17 00:35:02 -0500 (Thu, 17 Nov 2005) | 1 line
>
> Update FSF street address.
> ------------------------------------------------------------------------
> r11789 | hampton | 2005-11-02 15:32:42 -0500 (Wed, 02 Nov 2005) | 3 lines
>
> Use a dynamically allocated string for the version.
>
>
> The change that was made between 11964 and 11981 is this diff:
>
> --- gnc-splash.c        (revision 11964)
> +++ gnc-splash.c        (working copy)
> @@ -22,7 +22,8 @@
>
> #include "config.h"
>
> -#include <gnome.h>
> +#include <gtk/gtk.h>
> +#include <glib/gi18n.h>
>
> #include "gnc-gnome-utils.h"
> #include "gnc-splash.h"
>
> That change wont have affected this.  Sorry.  No, the problem is /still/
> not gnc-splash.c -- the problem is the generation of gnc-svninfo.h.  But
> then again I said that already but you don't seem to believe me.
>
>> You can see using 'svn log src/gnome-utils/gnc-splash.c' that that
>> file was changed on 2005-11-19 18:53:34 -0500.
>
> Yes. see above.  it's an irrelevant change.
>
>> Does this output look correct?
>>
>> tortho@inspiron:~/SVN/gnucash$ svninfo=`svn info $$s |grep '^Revision:
>> '|sed 's/Revision: //'` ;
>> tortho@inspiron:~/SVN/gnucash$ echo "#define GNUCASH_SVN_REV $$svninfo"
>> #define GNUCASH_SVN_REV 17734svninfo
>> tortho@inspiron:~/SVN/gnucash$
>
> No -- But what I handed you was a Makefile snippet and you're running
> it under the shell.  So I'm not surprised it doesn't look right.  Try
> running the following from your build directory src/gnome-utils:
>
>  svn info . | grep '^Revision: ' | sed 's/Revision: //'
>
>> Tor Harald
>
> -derek
>
> --
>       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
>       Member, MIT Student Information Processing Board  (SIPB)
>       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
>       [hidden email]                        PGP key available
>
> _______________________________________________
> gnucash-user mailing list
> [hidden email]
> https://lists.gnucash.org/mailman/listinfo/gnucash-user
>



--
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       [hidden email]                        PGP key available

_______________________________________________
gnucash-user mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-user
Reply | Threaded
Open this post in threaded view
|

Re: GnuCash wont build anymore (From SVN)

Tor Harald Thorland
Derek Atkins wrote:

> FYI,
>
> I've just committed a patch to SVN that should cause the build
> to fail during the generation of gnc-svninfo if the "svn info"
> fails..   So could you "svn update" and rebuild and tell me what
> it does?
>
> Thanks,
>
> -derek
>
> Quoting Derek Atkins <[hidden email]>:
>
>> Quoting Tor Harald Thorland <[hidden email]>:
>>
>>> As I said, I'm NOT a programmer, but what should the version definition
>>> look like?
>>
>>
>> If should be a number.
>>
>>> The thing here is that my last build was befor the following thing was
>>> changed.
>>
>>
>> Yes.  From "svn log gnc-splash.c":
>>
>> r11981 | hampton | 2005-11-19 18:53:34 -0500 (Sat, 19 Nov 2005) | 5
>> lines
>>
>> Include file cleanup.  Remove the messages.[ch] files in favor of the
>> glib supplied gi18n.h file.  Replace includes of gnome.h with gtk.h
>> (or better yet glib.h) wherever possible.  Don't include gnome.h from
>> any header files.  Remove some extraneous includes.
>>
>> ------------------------------------------------------------------------
>> r11964 | hampton | 2005-11-17 00:35:02 -0500 (Thu, 17 Nov 2005) | 1 line
>>
>> Update FSF street address.
>> ------------------------------------------------------------------------
>> r11789 | hampton | 2005-11-02 15:32:42 -0500 (Wed, 02 Nov 2005) | 3
>> lines
>>
>> Use a dynamically allocated string for the version.
>>
>>
>> The change that was made between 11964 and 11981 is this diff:
>>
>> --- gnc-splash.c        (revision 11964)
>> +++ gnc-splash.c        (working copy)
>> @@ -22,7 +22,8 @@
>>
>> #include "config.h"
>>
>> -#include <gnome.h>
>> +#include <gtk/gtk.h>
>> +#include <glib/gi18n.h>
>>
>> #include "gnc-gnome-utils.h"
>> #include "gnc-splash.h"
>>
>> That change wont have affected this.  Sorry.  No, the problem is /still/
>> not gnc-splash.c -- the problem is the generation of gnc-svninfo.h.  But
>> then again I said that already but you don't seem to believe me.
>>
>>> You can see using 'svn log src/gnome-utils/gnc-splash.c' that that
>>> file was changed on 2005-11-19 18:53:34 -0500.
>>
>>
>> Yes. see above.  it's an irrelevant change.
>>
>>> Does this output look correct?
>>>
>>> tortho@inspiron:~/SVN/gnucash$ svninfo=`svn info $$s |grep '^Revision:
>>> '|sed 's/Revision: //'` ;
>>> tortho@inspiron:~/SVN/gnucash$ echo "#define GNUCASH_SVN_REV $$svninfo"
>>> #define GNUCASH_SVN_REV 17734svninfo
>>> tortho@inspiron:~/SVN/gnucash$
>>
>>
>> No -- But what I handed you was a Makefile snippet and you're running
>> it under the shell.  So I'm not surprised it doesn't look right.  Try
>> running the following from your build directory src/gnome-utils:
>>
>>  svn info . | grep '^Revision: ' | sed 's/Revision: //'
>
>
Did run this, but no output. (It might be some other obvious things i
shall do with the next line but I'm not realy into this, both shell &
programming)
 svn info . | grep '^Revision: ' | sed 's/Revision: //'


But explain this! I did a svn update, and then builded the new version
of gnucash.

The splashscreen even showed the build ver 12015, so no problems...

WHY? Didn't you only supply a check for the version file..

Tor Harald

_______________________________________________
gnucash-user mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-user
Reply | Threaded
Open this post in threaded view
|

Re: GnuCash wont build anymore (From SVN)

Tor Harald Thorland
In reply to this post by Derek Atkins
Derek Atkins wrote:

> FYI,
>
> I've just committed a patch to SVN that should cause the build
> to fail during the generation of gnc-svninfo if the "svn info"
> fails..   So could you "svn update" and rebuild and tell me what
> it does?
>
As you can see in my other post it builds correctly today for some
reason....
The gnu-svninfo.h even contains the revision number today. It didnt
contain it yesterday.

Thanks
THT

> Thanks,
>
> -derek
>
> Quoting Derek Atkins <[hidden email]>:
>
>> Quoting Tor Harald Thorland <[hidden email]>:
>>
>>> As I said, I'm NOT a programmer, but what should the version definition
>>> look like?
>>
>>
>> If should be a number.
>>
>>> The thing here is that my last build was befor the following thing was
>>> changed.
>>
>>
>> Yes.  From "svn log gnc-splash.c":
>>
>> r11981 | hampton | 2005-11-19 18:53:34 -0500 (Sat, 19 Nov 2005) | 5
>> lines
>>
>> Include file cleanup.  Remove the messages.[ch] files in favor of the
>> glib supplied gi18n.h file.  Replace includes of gnome.h with gtk.h
>> (or better yet glib.h) wherever possible.  Don't include gnome.h from
>> any header files.  Remove some extraneous includes.
>>
>> ------------------------------------------------------------------------
>> r11964 | hampton | 2005-11-17 00:35:02 -0500 (Thu, 17 Nov 2005) | 1 line
>>
>> Update FSF street address.
>> ------------------------------------------------------------------------
>> r11789 | hampton | 2005-11-02 15:32:42 -0500 (Wed, 02 Nov 2005) | 3
>> lines
>>
>> Use a dynamically allocated string for the version.
>>
>>
>> The change that was made between 11964 and 11981 is this diff:
>>
>> --- gnc-splash.c        (revision 11964)
>> +++ gnc-splash.c        (working copy)
>> @@ -22,7 +22,8 @@
>>
>> #include "config.h"
>>
>> -#include <gnome.h>
>> +#include <gtk/gtk.h>
>> +#include <glib/gi18n.h>
>>
>> #include "gnc-gnome-utils.h"
>> #include "gnc-splash.h"
>>
>> That change wont have affected this.  Sorry.  No, the problem is /still/
>> not gnc-splash.c -- the problem is the generation of gnc-svninfo.h.  But
>> then again I said that already but you don't seem to believe me.
>>
>>> You can see using 'svn log src/gnome-utils/gnc-splash.c' that that
>>> file was changed on 2005-11-19 18:53:34 -0500.
>>
>>
>> Yes. see above.  it's an irrelevant change.
>>
>>> Does this output look correct?
>>>
>>> tortho@inspiron:~/SVN/gnucash$ svninfo=`svn info $$s |grep '^Revision:
>>> '|sed 's/Revision: //'` ;
>>> tortho@inspiron:~/SVN/gnucash$ echo "#define GNUCASH_SVN_REV $$svninfo"
>>> #define GNUCASH_SVN_REV 17734svninfo
>>> tortho@inspiron:~/SVN/gnucash$
>>
>>
>> No -- But what I handed you was a Makefile snippet and you're running
>> it under the shell.  So I'm not surprised it doesn't look right.  Try
>> running the following from your build directory src/gnome-utils:
>>
>>  svn info . | grep '^Revision: ' | sed 's/Revision: //'
>>
>>> Tor Harald
>>
>>
>> -derek
>>
>> --
>>       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
>>       Member, MIT Student Information Processing Board  (SIPB)
>>       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
>>       [hidden email]                        PGP key available
>>
>> _______________________________________________
>> gnucash-user mailing list
>> [hidden email]
>> https://lists.gnucash.org/mailman/listinfo/gnucash-user
>>
>
>
>

_______________________________________________
gnucash-user mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-user
Reply | Threaded
Open this post in threaded view
|

Re: GnuCash wont build anymore (From SVN)

Tor Harald Thorland
In reply to this post by Derek Atkins
Derek Atkins wrote:

> Quoting Derek Atkins <[hidden email]>:
>
>> Quoting Tor Harald Thorland <[hidden email]>:
>>
>>> As I said, I'm NOT a programmer, but what should the version definition
>>> look like?
>>
>>
>> If should be a number.
>>
>>> The thing here is that my last build was befor the following thing was
>>> changed.
>>
>>
>> Yes.  From "svn log gnc-splash.c":
>>
>> r11981 | hampton | 2005-11-19 18:53:34 -0500 (Sat, 19 Nov 2005) | 5
>> lines
>>
>> Include file cleanup.  Remove the messages.[ch] files in favor of the
>> glib supplied gi18n.h file.  Replace includes of gnome.h with gtk.h
>> (or better yet glib.h) wherever possible.  Don't include gnome.h from
>> any header files.  Remove some extraneous includes.
>>
>> ------------------------------------------------------------------------
>> r11964 | hampton | 2005-11-17 00:35:02 -0500 (Thu, 17 Nov 2005) | 1 line
>>
>> Update FSF street address.
>> ------------------------------------------------------------------------
>> r11789 | hampton | 2005-11-02 15:32:42 -0500 (Wed, 02 Nov 2005) | 3
>> lines
>>
>> Use a dynamically allocated string for the version.
>>
>>
>> The change that was made between 11964 and 11981 is this diff:
>>
>> --- gnc-splash.c        (revision 11964)
>> +++ gnc-splash.c        (working copy)
>> @@ -22,7 +22,8 @@
>>
>> #include "config.h"
>>
>> -#include <gnome.h>
>> +#include <gtk/gtk.h>
>> +#include <glib/gi18n.h>
>>
>> #include "gnc-gnome-utils.h"
>> #include "gnc-splash.h"
>>
>> That change wont have affected this.  Sorry.  No, the problem is /still/
>> not gnc-splash.c -- the problem is the generation of gnc-svninfo.h.  But
>> then again I said that already but you don't seem to believe me.
>>
It's not that I dont belive you, It is just that as I have stated a
couple of times now: I am NOT a programmer, and this is my first program
wich is not installed with synaptics/apt-get or yum.
I have downloaded and spent some of my spare time to try to help GnuCash
with the Translation to Norwegian. Until now, I have needed more help
than I can give (for a little while) to get a working copy for the
translation purpose.

I have not even started using GnuCash for any work yet, but is trying to
help with the development only because I belive in Linux with its
programs and its support, and hopefully this is one of the programs wich
I still have to use windows for.

So, what I'm trying to say is that I don't understand (but I try) this
programming/shell commands and how this files work together. I would
like to get the grip on these things but then I need to be instructed.
And I'm only this to try to help.

Until the last couple of mails I didn't know how the XX.h files was
generated. (I at least think I know now that they are made from the
makefile.)

Tor Harald Thorland
_______________________________________________
gnucash-user mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-user
Reply | Threaded
Open this post in threaded view
|

Re: GnuCash wont build anymore (From SVN)

Derek Atkins
In reply to this post by Tor Harald Thorland
Quoting Tor Harald Thorland <[hidden email]>:

>>>  svn info . | grep '^Revision: ' | sed 's/Revision: //'
>>
>>
> Did run this, but no output. (It might be some other obvious things i
> shall do with the next line but I'm not realy into this, both shell &
> programming)
> svn info . | grep '^Revision: ' | sed 's/Revision: //'
>
>
> But explain this! I did a svn update, and then builded the new version
> of gnucash.
>
> The splashscreen even showed the build ver 12015, so no problems...
>
> WHY? Didn't you only supply a check for the version file..

no, I did more to it..  In particular it was pointed out to me that
if you're running in a non-English locale it's possible that "svn info"
isn't printing out the string "Revision: ..." -- so the code would
fail to find the revision.

I changed the Makefile so it runs "svn info" in the C locale to
force it to output English..  So it shouldn't fail anymore.

> Tor Harald

-derek

--
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       [hidden email]                        PGP key available

_______________________________________________
gnucash-user mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-user
Reply | Threaded
Open this post in threaded view
|

Re: GnuCash wont build anymore (From SVN)

Tor Harald Thorland
Derek Atkins wrote:

> Quoting Tor Harald Thorland <[hidden email]>:
>
>>>>  svn info . | grep '^Revision: ' | sed 's/Revision: //'
>>>
>>>
>>>
>> Did run this, but no output. (It might be some other obvious things i
>> shall do with the next line but I'm not realy into this, both shell &
>> programming)
>> svn info . | grep '^Revision: ' | sed 's/Revision: //'
>>
>>
>> But explain this! I did a svn update, and then builded the new version
>> of gnucash.
>>
>> The splashscreen even showed the build ver 12015, so no problems...
>>
>> WHY? Didn't you only supply a check for the version file..
>
>
> no, I did more to it..  In particular it was pointed out to me that
> if you're running in a non-English locale it's possible that "svn info"
> isn't printing out the string "Revision: ..." -- so the code would
> fail to find the revision.
>
> I changed the Makefile so it runs "svn info" in the C locale to
> force it to output English..  So it shouldn't fail anymore.
>
So this is my system sending out a norwegian string to it.
Thanks a lot for the help. I built it 2 times now just to check and it
works perfect.

Tor Harald
_______________________________________________
gnucash-user mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-user
Reply | Threaded
Open this post in threaded view
|

Re: GnuCash wont build anymore (From SVN)

Derek Atkins
Quoting Tor Harald Thorland <[hidden email]>:

>> I changed the Makefile so it runs "svn info" in the C locale to
>> force it to output English..  So it shouldn't fail anymore.
>>
> So this is my system sending out a norwegian string to it.
> Thanks a lot for the help. I built it 2 times now just to check and it
> works perfect.

Yea.  I should've just asked:

  what do you get from "svn info ."

...  Sorry.   But I'm glad it's working again.

> Tor Harald

-derek
--
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       [hidden email]                        PGP key available

_______________________________________________
gnucash-user mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-user
Reply | Threaded
Open this post in threaded view
|

Re: GnuCash wont build anymore (From SVN)

Tor Harald Thorland
Derek Atkins wrote:

> Quoting Tor Harald Thorland <[hidden email]>:
>
>>> I changed the Makefile so it runs "svn info" in the C locale to
>>> force it to output English..  So it shouldn't fail anymore.
>>>
>> So this is my system sending out a norwegian string to it.
>> Thanks a lot for the help. I built it 2 times now just to check and it
>> works perfect.
>
>
> Yea.  I should've just asked:
>
>  what do you get from "svn info ."
>
> ...  Sorry.   But I'm glad it's working again.
>
>> Tor Harald
>
>
> -derek

Here is the output. But is it changed something to this now.. since it
worked earlyer..

tortho@inspiron:~/SVN/gnucash$ svn info
Filsti: .
Nettadresse: http://svn.gnucash.org/repo/gnucash/trunk
Depotets UUID: 57a11ea4-9604-0410-9ed3-97b8803252fd
Revisjon: 12015
Nodetype: Katalog
Oppgave: Normal
Sist endret av: hampton
Siste endrede revisjon: 12015
Dato for siste endring: 2005-11-22 05:08:47 +0100 (tir, 22 nov 2005)
Egenskaper er sist oppdatert: 2005-11-21 22:38:47 +0100 (man, 21 nov 2005)

tortho@inspiron:~/SVN/gnucash$


Tor Harald
_______________________________________________
gnucash-user mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-user
Reply | Threaded
Open this post in threaded view
|

Re: GnuCash wont build anymore (From SVN)

Derek Atkins
Quoting Tor Harald Thorland <[hidden email]>:

> Here is the output. But is it changed something to this now.. since it
> worked earlyer..

I'm sure something changed on your system.. Perhaps you changed your
default locale?  But yea, this:

> tortho@inspiron:~/SVN/gnucash$ svn info
> Filsti: .
> Nettadresse: http://svn.gnucash.org/repo/gnucash/trunk
> Depotets UUID: 57a11ea4-9604-0410-9ed3-97b8803252fd
> Revisjon: 12015
> Nodetype: Katalog
> Oppgave: Normal
> Sist endret av: hampton
> Siste endrede revisjon: 12015
> Dato for siste endring: 2005-11-22 05:08:47 +0100 (tir, 22 nov 2005)
> Egenskaper er sist oppdatert: 2005-11-21 22:38:47 +0100 (man, 21 nov 2005)

... shows quite clearly why the build failed.  :)

If you run: LANG=C svn info .
It should print out in English... Which is what the Makefile does now.

Enjoy!

-derek
--
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       [hidden email]                        PGP key available

_______________________________________________
gnucash-user mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-user