[GNC-dev] Test failure

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[GNC-dev] Test failure

Stephen M. Butler
Found this patch on the debian version for 3.4

Origin: upstream, https://bugs.gnucash.org/attachment.cgi?id=373094
Bug-Upstream: https://bugs.gnucash.org/show_bug.cgi?id=797008
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=918057
From: Maxim Cournoyer <[hidden email]>
Date: Wed, 2 Jan 2019 14:46:28 -0500
Subject: tests: Fix a test failure in test-transaction.scm.

With the New Year upon us, a test which was hard-coded to use 2018 now
failed.

Fixes issue #797008 (see:
https://bugs.gnucash.org/show_bug.cgi?id=797008).

* gnucash/report/standard-reports/test/test-transaction.scm:
(trep-tests): Use the current year in the test string instead of a
static one.

--- a/gnucash/report/standard-reports/test/test-transaction.scm
+++ b/gnucash/report/standard-reports/test/test-transaction.scm
@@ -4,8 +4,9 @@
 (use-modules (gnucash report standard-reports transaction))
 (use-modules (gnucash report stylesheets))
 (use-modules (gnucash report report-system))
 (use-modules (gnucash report report-system test test-extras))
+(use-modules (srfi srfi-19))
 (use-modules (srfi srfi-64))
 (use-modules (gnucash engine test srfi64-extras))
 (use-modules (sxml simple))
 (use-modules (sxml xpath))
@@ -642,18 +643,20 @@
       (set-option! options "General" "Common Currency" #t)
       (set-option! options "General" "Show original currency amount" #t)
       (set-option! options "Sorting" "Primary Key" 'date)
       (set-option! options "Sorting" "Primary Subtotal for Date Key" 'none)
-      (let* ((sxml (options->sxml options "dual columns")))
+      (let* ((sxml (options->sxml options "dual columns"))
+         (current-year (date->string (current-date) "~y")))
         (test-equal "dual amount column, with original currency headers"
           (list "Date" "Num" "Description" "Memo/Notes" "Account"
                 "Debit (USD)" "Credit (USD)" "Debit" "Credit")
           (get-row-col sxml 0 #f))
         (test-equal "dual amount column, grand totals available"
           (list "Grand Total" "$2,280.00" "$2,280.00")
           (get-row-col sxml -1 #f))
         (test-equal "dual amount column, first transaction correct"
-          (list "01/03/18" "$103 income" "Root.Asset.Bank" "$103.00"
"$103.00")
+          (list (string-append "01/03/" current-year) "$103 income"
+        "Root.Asset.Bank" "$103.00" "$103.00")
           (get-row-col sxml 1 #f)))
       )
 
     (test-end "display options")


--
Stephen M Butler, PMP, PSM
[hidden email]
[hidden email]
253-350-0166
-------------------------------------------
GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] Test failure

Christopher Lam
Stephen this bug is in 3.4 and was fixed in commit 95bee405c

Could you try "git revert e31f4c3f9" as a test for your "31/12/70"
test-transaction errors?

On 24/1/19 3:05 am, Stephen M. Butler wrote:

> Found this patch on the debian version for 3.4
>
> Origin: upstream, https://bugs.gnucash.org/attachment.cgi?id=373094
> Bug-Upstream: https://bugs.gnucash.org/show_bug.cgi?id=797008
> Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=918057
> From: Maxim Cournoyer <[hidden email]>
> Date: Wed, 2 Jan 2019 14:46:28 -0500
> Subject: tests: Fix a test failure in test-transaction.scm.
>
> With the New Year upon us, a test which was hard-coded to use 2018 now
> failed.
>
> Fixes issue #797008 (see:
> https://bugs.gnucash.org/show_bug.cgi?id=797008).
>
> * gnucash/report/standard-reports/test/test-transaction.scm:
> (trep-tests): Use the current year in the test string instead of a
> static one.
>
> --- a/gnucash/report/standard-reports/test/test-transaction.scm
> +++ b/gnucash/report/standard-reports/test/test-transaction.scm
> @@ -4,8 +4,9 @@
>   (use-modules (gnucash report standard-reports transaction))
>   (use-modules (gnucash report stylesheets))
>   (use-modules (gnucash report report-system))
>   (use-modules (gnucash report report-system test test-extras))
> +(use-modules (srfi srfi-19))
>   (use-modules (srfi srfi-64))
>   (use-modules (gnucash engine test srfi64-extras))
>   (use-modules (sxml simple))
>   (use-modules (sxml xpath))
> @@ -642,18 +643,20 @@
>         (set-option! options "General" "Common Currency" #t)
>         (set-option! options "General" "Show original currency amount" #t)
>         (set-option! options "Sorting" "Primary Key" 'date)
>         (set-option! options "Sorting" "Primary Subtotal for Date Key" 'none)
> -      (let* ((sxml (options->sxml options "dual columns")))
> +      (let* ((sxml (options->sxml options "dual columns"))
> +         (current-year (date->string (current-date) "~y")))
>           (test-equal "dual amount column, with original currency headers"
>             (list "Date" "Num" "Description" "Memo/Notes" "Account"
>                   "Debit (USD)" "Credit (USD)" "Debit" "Credit")
>             (get-row-col sxml 0 #f))
>           (test-equal "dual amount column, grand totals available"
>             (list "Grand Total" "$2,280.00" "$2,280.00")
>             (get-row-col sxml -1 #f))
>           (test-equal "dual amount column, first transaction correct"
> -          (list "01/03/18" "$103 income" "Root.Asset.Bank" "$103.00"
> "$103.00")
> +          (list (string-append "01/03/" current-year) "$103 income"
> +        "Root.Asset.Bank" "$103.00" "$103.00")
>             (get-row-col sxml 1 #f)))
>         )
>  
>       (test-end "display options")
>
>
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] Test failure

Stephen M. Butler
On 1/24/19 2:32 AM, Christopher Lam wrote:
> Stephen this bug is in 3.4 and was fixed in commit 95bee405c
>
> Could you try "git revert e31f4c3f9" as a test for your "31/12/70"
> test-transaction errors?


That worked.  Thank you.  BTW, how did you find that it was fixed?  I
ask, because there is another one:

-rw-r--r-- 1 steve steve 461 Jan 23 14:16
test--skip-test-stress-options.patch

 cat test*
Last-Update: 2018-10-02
Forwarded: not-needed
Bug-Upstream: https://bugs.gnucash.org/show_bug.cgi?id=796877
Author: Dmitry Smirnov <[hidden email]>
Description: skip broken test

--- a/gnucash/report/standard-reports/test/CMakeLists.txt
+++ b/gnucash/report/standard-reports/test/CMakeLists.txt
@@ -13,9 +13,8 @@
   test-income-gst.scm
 )
 
 set(scm_test_with_textual_ports_SOURCES
-    test-stress-options.scm
 )
 
 set(GUILE_DEPENDS
   scm-gnc-module

==================

Any way I can search and see if this patch is already in maint?


>
> On 24/1/19 3:05 am, Stephen M. Butler wrote:
>> Found this patch on the debian version for 3.4
>>
>> Origin: upstream, https://bugs.gnucash.org/attachment.cgi?id=373094
>> Bug-Upstream: https://bugs.gnucash.org/show_bug.cgi?id=797008
>> Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=918057
>> From: Maxim Cournoyer <[hidden email]>
>> Date: Wed, 2 Jan 2019 14:46:28 -0500
>> Subject: tests: Fix a test failure in test-transaction.scm.
>>
>> With the New Year upon us, a test which was hard-coded to use 2018 now
>> failed.
>>
>> Fixes issue #797008 (see:
>> https://bugs.gnucash.org/show_bug.cgi?id=797008).
>>
>> * gnucash/report/standard-reports/test/test-transaction.scm:
>> (trep-tests): Use the current year in the test string instead of a
>> static one.
>>
>> --- a/gnucash/report/standard-reports/test/test-transaction.scm
>> +++ b/gnucash/report/standard-reports/test/test-transaction.scm
>> @@ -4,8 +4,9 @@
>>   (use-modules (gnucash report standard-reports transaction))
>>   (use-modules (gnucash report stylesheets))
>>   (use-modules (gnucash report report-system))
>>   (use-modules (gnucash report report-system test test-extras))
>> +(use-modules (srfi srfi-19))
>>   (use-modules (srfi srfi-64))
>>   (use-modules (gnucash engine test srfi64-extras))
>>   (use-modules (sxml simple))
>>   (use-modules (sxml xpath))
>> @@ -642,18 +643,20 @@
>>         (set-option! options "General" "Common Currency" #t)
>>         (set-option! options "General" "Show original currency
>> amount" #t)
>>         (set-option! options "Sorting" "Primary Key" 'date)
>>         (set-option! options "Sorting" "Primary Subtotal for Date
>> Key" 'none)
>> -      (let* ((sxml (options->sxml options "dual columns")))
>> +      (let* ((sxml (options->sxml options "dual columns"))
>> +         (current-year (date->string (current-date) "~y")))
>>           (test-equal "dual amount column, with original currency
>> headers"
>>             (list "Date" "Num" "Description" "Memo/Notes" "Account"
>>                   "Debit (USD)" "Credit (USD)" "Debit" "Credit")
>>             (get-row-col sxml 0 #f))
>>           (test-equal "dual amount column, grand totals available"
>>             (list "Grand Total" "$2,280.00" "$2,280.00")
>>             (get-row-col sxml -1 #f))
>>           (test-equal "dual amount column, first transaction correct"
>> -          (list "01/03/18" "$103 income" "Root.Asset.Bank" "$103.00"
>> "$103.00")
>> +          (list (string-append "01/03/" current-year) "$103 income"
>> +        "Root.Asset.Bank" "$103.00" "$103.00")
>>             (get-row-col sxml 1 #f)))
>>         )
>>         (test-end "display options")
>>
>>
> _______________________________________________
> gnucash-devel mailing list
> [hidden email]
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel


--
Stephen M Butler, PMP, PSM
[hidden email]
[hidden email]
253-350-0166
-------------------------------------------
GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] Test failure

Christopher Lam
Because e31f4c3f9 is causing errors on my build as well in different ways.

PS e31f4c3f9 must not be reverted for your packaging - please be patient
while a proper fix is pending.

On 25/1/19 3:48 am, Stephen M. Butler wrote:

> On 1/24/19 2:32 AM, Christopher Lam wrote:
>> Stephen this bug is in 3.4 and was fixed in commit 95bee405c
>>
>> Could you try "git revert e31f4c3f9" as a test for your "31/12/70"
>> test-transaction errors?
>
> That worked.  Thank you.  BTW, how did you find that it was fixed?  I
> ask, because there is another one:
>
> -rw-r--r-- 1 steve steve 461 Jan 23 14:16
> test--skip-test-stress-options.patch
>
>   cat test*
> Last-Update: 2018-10-02
> Forwarded: not-needed
> Bug-Upstream: https://bugs.gnucash.org/show_bug.cgi?id=796877
> Author: Dmitry Smirnov <[hidden email]>
> Description: skip broken test
>
> --- a/gnucash/report/standard-reports/test/CMakeLists.txt
> +++ b/gnucash/report/standard-reports/test/CMakeLists.txt
> @@ -13,9 +13,8 @@
>     test-income-gst.scm
>   )
>  
>   set(scm_test_with_textual_ports_SOURCES
> -    test-stress-options.scm
>   )
>  
>   set(GUILE_DEPENDS
>     scm-gnc-module
>
> ==================
>
> Any way I can search and see if this patch is already in maint?
>
>
>> On 24/1/19 3:05 am, Stephen M. Butler wrote:
>>> Found this patch on the debian version for 3.4
>>>
>>> Origin: upstream, https://bugs.gnucash.org/attachment.cgi?id=373094
>>> Bug-Upstream: https://bugs.gnucash.org/show_bug.cgi?id=797008
>>> Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=918057
>>> From: Maxim Cournoyer <[hidden email]>
>>> Date: Wed, 2 Jan 2019 14:46:28 -0500
>>> Subject: tests: Fix a test failure in test-transaction.scm.
>>>
>>> With the New Year upon us, a test which was hard-coded to use 2018 now
>>> failed.
>>>
>>> Fixes issue #797008 (see:
>>> https://bugs.gnucash.org/show_bug.cgi?id=797008).
>>>
>>> * gnucash/report/standard-reports/test/test-transaction.scm:
>>> (trep-tests): Use the current year in the test string instead of a
>>> static one.
>>>
>>> --- a/gnucash/report/standard-reports/test/test-transaction.scm
>>> +++ b/gnucash/report/standard-reports/test/test-transaction.scm
>>> @@ -4,8 +4,9 @@
>>>    (use-modules (gnucash report standard-reports transaction))
>>>    (use-modules (gnucash report stylesheets))
>>>    (use-modules (gnucash report report-system))
>>>    (use-modules (gnucash report report-system test test-extras))
>>> +(use-modules (srfi srfi-19))
>>>    (use-modules (srfi srfi-64))
>>>    (use-modules (gnucash engine test srfi64-extras))
>>>    (use-modules (sxml simple))
>>>    (use-modules (sxml xpath))
>>> @@ -642,18 +643,20 @@
>>>          (set-option! options "General" "Common Currency" #t)
>>>          (set-option! options "General" "Show original currency
>>> amount" #t)
>>>          (set-option! options "Sorting" "Primary Key" 'date)
>>>          (set-option! options "Sorting" "Primary Subtotal for Date
>>> Key" 'none)
>>> -      (let* ((sxml (options->sxml options "dual columns")))
>>> +      (let* ((sxml (options->sxml options "dual columns"))
>>> +         (current-year (date->string (current-date) "~y")))
>>>            (test-equal "dual amount column, with original currency
>>> headers"
>>>              (list "Date" "Num" "Description" "Memo/Notes" "Account"
>>>                    "Debit (USD)" "Credit (USD)" "Debit" "Credit")
>>>              (get-row-col sxml 0 #f))
>>>            (test-equal "dual amount column, grand totals available"
>>>              (list "Grand Total" "$2,280.00" "$2,280.00")
>>>              (get-row-col sxml -1 #f))
>>>            (test-equal "dual amount column, first transaction correct"
>>> -          (list "01/03/18" "$103 income" "Root.Asset.Bank" "$103.00"
>>> "$103.00")
>>> +          (list (string-append "01/03/" current-year) "$103 income"
>>> +        "Root.Asset.Bank" "$103.00" "$103.00")
>>>              (get-row-col sxml 1 #f)))
>>>          )
>>>          (test-end "display options")
>>>
>>>
>> _______________________________________________
>> gnucash-devel mailing list
>> [hidden email]
>> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] Test failure

Stephen M. Butler
OH!  Light bulb on!
OK.  I understand what you said earlier.  I'll put the patches back into
the packaging.

Thanks for clearing that up.

--Steve

PS Looking in manual for 'revert' command.



On 1/24/19 1:06 PM, Christopher Lam wrote:

> Because e31f4c3f9 is causing errors on my build as well in different
> ways.
>
> PS e31f4c3f9 must not be reverted for your packaging - please be
> patient while a proper fix is pending.
>
> On 25/1/19 3:48 am, Stephen M. Butler wrote:
>> On 1/24/19 2:32 AM, Christopher Lam wrote:
>>> Stephen this bug is in 3.4 and was fixed in commit 95bee405c
>>>
>>> Could you try "git revert e31f4c3f9" as a test for your "31/12/70"
>>> test-transaction errors?
>>
>> That worked.  Thank you.  BTW, how did you find that it was fixed?  I
>> ask, because there is another one: 01/24/2019
>>
>> -rw-r--r-- 1 steve steve 461 Jan 23 14:16
>> test--skip-test-stress-options.patch
>>
>>   cat test*
>> Last-Update: 2018-10-02
>> Forwarded: not-needed
>> Bug-Upstream: https://bugs.gnucash.org/show_bug.cgi?id=796877
>> Author: Dmitry Smirnov <[hidden email]>
>> Description: skip broken test
>>
>> --- a/gnucash/report/standard-reports/test/CMakeLists.txt
>> +++ b/gnucash/report/standard-reports/test/CMakeLists.txt
>> @@ -13,9 +13,8 @@
>>     test-income-gst.scm
>>   )
>>     set(scm_test_with_textual_ports_SOURCES
>> -    test-stress-options.scm
>>   )
>>     set(GUILE_DEPENDS
>>     scm-gnc-module
>>
>> ==================
>>
>> Any way I can search and see if this patch is already in maint?
>>
>>
>>> On 24/1/19 3:05 am, Stephen M. Butler wrote:
>>>> Found this patch on the debian version for 3.4
>>>>
>>>> Origin: upstream, https://bugs.gnucash.org/attachment.cgi?id=373094
>>>> Bug-Upstream: https://bugs.gnucash.org/show_bug.cgi?id=797008
>>>> Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=918057
>>>> From: Maxim Cournoyer <[hidden email]>
>>>> Date: Wed, 2 Jan 2019 14:46:28 -0500
>>>> Subject: tests: Fix a test failure in test-transaction.scm.
>>>>
>>>> With the New Year upon us, a test which was hard-coded to use 2018 now
>>>> failed.
>>>>
>>>> Fixes issue #797008 (see:
>>>> https://bugs.gnucash.org/show_bug.cgi?id=797008).
>>>>
>>>> * gnucash/report/standard-reports/test/test-transaction.scm:
>>>> (trep-tests): Use the current year in the test string instead of a
>>>> static one.
>>>>
>>>> --- a/gnucash/report/standard-reports/test/test-transaction.scm
>>>> +++ b/gnucash/report/standard-reports/test/test-transaction.scm
>>>> @@ -4,8 +4,9 @@
>>>>    (use-modules (gnucash report standard-reports transaction))
>>>>    (use-modules (gnucash report stylesheets))
>>>>    (use-modules (gnucash report report-system))
>>>>    (use-modules (gnucash report report-system test test-extras))
>>>> +(use-modules (srfi srfi-19))
>>>>    (use-modules (srfi srfi-64))
>>>>    (use-modules (gnucash engine test srfi64-extras))
>>>>    (use-modules (sxml simple))
>>>>    (use-modules (sxml xpath))
>>>> @@ -642,18 +643,20 @@
>>>>          (set-option! options "General" "Common Currency" #t)
>>>>          (set-option! options "General" "Show original currency
>>>> amount" #t)
>>>>          (set-option! options "Sorting" "Primary Key" 'date)
>>>>          (set-option! options "Sorting" "Primary Subtotal for Date
>>>> Key" 'none)
>>>> -      (let* ((sxml (options->sxml options "dual columns")))
>>>> +      (let* ((sxml (options->sxml options "dual columns"))
>>>> +         (current-year (date->string (current-date) "~y")))
>>>>            (test-equal "dual amount column, with original currency
>>>> headers"
>>>>              (list "Date" "Num" "Description" "Memo/Notes" "Account"
>>>>                    "Debit (USD)" "Credit (USD)" "Debit" "Credit")
>>>>              (get-row-col sxml 0 #f))
>>>>            (test-equal "dual amount column, grand totals available"
>>>>              (list "Grand Total" "$2,280.00" "$2,280.00")
>>>>              (get-row-col sxml -1 #f))
>>>>            (test-equal "dual amount column, first transaction correct"
>>>> -          (list "01/03/18" "$103 income" "Root.Asset.Bank" "$103.00"
>>>> "$103.00")
>>>> +          (list (string-append "01/03/" current-year) "$103 income"
>>>> +        "Root.Asset.Bank" "$103.00" "$103.00")
>>>>              (get-row-col sxml 1 #f)))
>>>>          ) 01/24/2019
>>>>          (test-end "display options")
>>>>
>>>>
>>> _______________________________________________
>>> gnucash-devel mailing list
>>> [hidden email]
>>> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>>
> _______________________________________________
> gnucash-devel mailing list
> [hidden email]
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel


--
Stephen M Butler, PMP, PSM
[hidden email]
[hidden email]
253-350-0166
-------------------------------------------
GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] Test failure

Christopher Lam
Revert is a git terminology, not a gnucash one. Welcome to version control.

Please remember this revert is reverting a buggy code with a previous buggy
code, so, cannot be consisted safe to package; best wait until the clever
devs can find a proper fix for gnc-date.

On Fri., 25 Jan. 2019, 05:46 Stephen M. Butler <[hidden email] wrote:

> OH!  Light bulb on!
> OK.  I understand what you said earlier.  I'll put the patches back into
> the packaging.
>
> Thanks for clearing that up.
>
> --Steve
>
> PS Looking in manual for 'revert' command.
>
>
>
> On 1/24/19 1:06 PM, Christopher Lam wrote:
> > Because e31f4c3f9 is causing errors on my build as well in different
> > ways.
> >
> > PS e31f4c3f9 must not be reverted for your packaging - please be
> > patient while a proper fix is pending.
> >
> > On 25/1/19 3:48 am, Stephen M. Butler wrote:
> >> On 1/24/19 2:32 AM, Christopher Lam wrote:
> >>> Stephen this bug is in 3.4 and was fixed in commit 95bee405c
> >>>
> >>> Could you try "git revert e31f4c3f9" as a test for your "31/12/70"
> >>> test-transaction errors?
> >>
> >> That worked.  Thank you.  BTW, how did you find that it was fixed?  I
> >> ask, because there is another one: 01/24/2019
> >>
> >> -rw-r--r-- 1 steve steve 461 Jan 23 14:16
> >> test--skip-test-stress-options.patch
> >>
> >>   cat test*
> >> Last-Update: 2018-10-02
> >> Forwarded: not-needed
> >> Bug-Upstream: https://bugs.gnucash.org/show_bug.cgi?id=796877
> >> Author: Dmitry Smirnov <[hidden email]>
> >> Description: skip broken test
> >>
> >> --- a/gnucash/report/standard-reports/test/CMakeLists.txt
> >> +++ b/gnucash/report/standard-reports/test/CMakeLists.txt
> >> @@ -13,9 +13,8 @@
> >>     test-income-gst.scm
> >>   )
> >>     set(scm_test_with_textual_ports_SOURCES
> >> -    test-stress-options.scm
> >>   )
> >>     set(GUILE_DEPENDS
> >>     scm-gnc-module
> >>
> >> ==================
> >>
> >> Any way I can search and see if this patch is already in maint?
> >>
> >>
> >>> On 24/1/19 3:05 am, Stephen M. Butler wrote:
> >>>> Found this patch on the debian version for 3.4
> >>>>
> >>>> Origin: upstream, https://bugs.gnucash.org/attachment.cgi?id=373094
> >>>> Bug-Upstream: https://bugs.gnucash.org/show_bug.cgi?id=797008
> >>>> Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=918057
> >>>> From: Maxim Cournoyer <[hidden email]>
> >>>> Date: Wed, 2 Jan 2019 14:46:28 -0500
> >>>> Subject: tests: Fix a test failure in test-transaction.scm.
> >>>>
> >>>> With the New Year upon us, a test which was hard-coded to use 2018 now
> >>>> failed.
> >>>>
> >>>> Fixes issue #797008 (see:
> >>>> https://bugs.gnucash.org/show_bug.cgi?id=797008).
> >>>>
> >>>> * gnucash/report/standard-reports/test/test-transaction.scm:
> >>>> (trep-tests): Use the current year in the test string instead of a
> >>>> static one.
> >>>>
> >>>> --- a/gnucash/report/standard-reports/test/test-transaction.scm
> >>>> +++ b/gnucash/report/standard-reports/test/test-transaction.scm
> >>>> @@ -4,8 +4,9 @@
> >>>>    (use-modules (gnucash report standard-reports transaction))
> >>>>    (use-modules (gnucash report stylesheets))
> >>>>    (use-modules (gnucash report report-system))
> >>>>    (use-modules (gnucash report report-system test test-extras))
> >>>> +(use-modules (srfi srfi-19))
> >>>>    (use-modules (srfi srfi-64))
> >>>>    (use-modules (gnucash engine test srfi64-extras))
> >>>>    (use-modules (sxml simple))
> >>>>    (use-modules (sxml xpath))
> >>>> @@ -642,18 +643,20 @@
> >>>>          (set-option! options "General" "Common Currency" #t)
> >>>>          (set-option! options "General" "Show original currency
> >>>> amount" #t)
> >>>>          (set-option! options "Sorting" "Primary Key" 'date)
> >>>>          (set-option! options "Sorting" "Primary Subtotal for Date
> >>>> Key" 'none)
> >>>> -      (let* ((sxml (options->sxml options "dual columns")))
> >>>> +      (let* ((sxml (options->sxml options "dual columns"))
> >>>> +         (current-year (date->string (current-date) "~y")))
> >>>>            (test-equal "dual amount column, with original currency
> >>>> headers"
> >>>>              (list "Date" "Num" "Description" "Memo/Notes" "Account"
> >>>>                    "Debit (USD)" "Credit (USD)" "Debit" "Credit")
> >>>>              (get-row-col sxml 0 #f))
> >>>>            (test-equal "dual amount column, grand totals available"
> >>>>              (list "Grand Total" "$2,280.00" "$2,280.00")
> >>>>              (get-row-col sxml -1 #f))
> >>>>            (test-equal "dual amount column, first transaction correct"
> >>>> -          (list "01/03/18" "$103 income" "Root.Asset.Bank" "$103.00"
> >>>> "$103.00")
> >>>> +          (list (string-append "01/03/" current-year) "$103 income"
> >>>> +        "Root.Asset.Bank" "$103.00" "$103.00")
> >>>>              (get-row-col sxml 1 #f)))
> >>>>          ) 01/24/2019
> >>>>          (test-end "display options")
> >>>>
> >>>>
> >>> _______________________________________________
> >>> gnucash-devel mailing list
> >>> [hidden email]
> >>> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
> >>
> > _______________________________________________
> > gnucash-devel mailing list
> > [hidden email]
> > https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>
>
> --
> Stephen M Butler, PMP, PSM
> [hidden email]
> [hidden email]
> 253-350-0166
> -------------------------------------------
> GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8
>
> _______________________________________________
> gnucash-devel mailing list
> [hidden email]
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] Test failure

Stephen M. Butler
On 1/24/19 7:36 PM, Christopher Lam wrote:
> Revert is a git terminology, not a gnucash one. Welcome to version
> control.

That's the manual to which I referred.  It meant something else to my
mind when I first saw your post.  But, after further thought, my
previous thought was faulty.


My first boss after college would draw a picture to describe the
difference between a bug and a feature.

I can't draw so a word will have to do (at less than a thousand words)!

BUG:  draw stick figure.


FEATURE:  Add pants, tie, gloves, shoes and a top hat.


MORAL:  A feature is a bug all dressed up and ready to go out.

>
> Please remember this revert is reverting a buggy code with a previous
> buggy code, so, cannot be consisted safe to package; best wait until
> the clever devs can find a proper fix for gnc-date.
>
> On Fri., 25 Jan. 2019, 05:46 Stephen M. Butler <[hidden email]
> <mailto:[hidden email]> wrote:
>
>     OH!  Light bulb on!
>     OK.  I understand what you said earlier.  I'll put the patches
>     back into
>     the packaging.
>
>     Thanks for clearing that up.
>
>     --Steve
>
>     PS Looking in manual for 'revert' command.
>

--
Stephen M Butler, PMP, PSM
[hidden email]
[hidden email]
253-350-0166
-------------------------------------------
GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8


_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] Test failure

Christopher Lam
Another experiment. Try prefix your build with "TZ=UTC " on current maint.

Eg if using ninja, it'll be "TZ=UTC ninja check"

On Fri., 25 Jan. 2019, 11:52 Stephen M. Butler <[hidden email] wrote:

> On 1/24/19 7:36 PM, Christopher Lam wrote:
> > Revert is a git terminology, not a gnucash one. Welcome to version
> > control.
>
> That's the manual to which I referred.  It meant something else to my
> mind when I first saw your post.  But, after further thought, my
> previous thought was faulty.
>
>
> My first boss after college would draw a picture to describe the
> difference between a bug and a feature.
>
> I can't draw so a word will have to do (at less than a thousand words)!
>
> BUG:  draw stick figure.
>
>
> FEATURE:  Add pants, tie, gloves, shoes and a top hat.
>
>
> MORAL:  A feature is a bug all dressed up and ready to go out.
>
> >
> > Please remember this revert is reverting a buggy code with a previous
> > buggy code, so, cannot be consisted safe to package; best wait until
> > the clever devs can find a proper fix for gnc-date.
> >
> > On Fri., 25 Jan. 2019, 05:46 Stephen M. Butler <[hidden email]
> > <mailto:[hidden email]> wrote:
> >
> >     OH!  Light bulb on!
> >     OK.  I understand what you said earlier.  I'll put the patches
> >     back into
> >     the packaging.
> >
> >     Thanks for clearing that up.
> >
> >     --Steve
> >
> >     PS Looking in manual for 'revert' command.
> >
>
> --
> Stephen M Butler, PMP, PSM
> [hidden email]
> [hidden email]
> 253-350-0166
> -------------------------------------------
> GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8
>
>
>
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] Test failure

Stephen M. Butler
On 1/26/19 3:13 AM, Christopher Lam wrote:
> Another experiment. Try prefix your build with "TZ=UTC " on current
> maint.
>
> Eg if using ninja, it'll be "TZ=UTC ninja check"


TZ=UTC dpkg- -rfakeroot -b -uc

....

End testing: Jan 27 01:47 UTC
+ exit 2
debian/rules:65: recipe for target 'override_dh_auto_test' failed
make[1]: *** [override_dh_auto_test] Error 2
make[1]: Leaving directory '/home/steve/Projects/GnuCash/gnucash'
debian/rules:24: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2

Same error -- Test 109 that fails.


This is with the patches for 3.4.  I verified before Sabbath that 3.4
builds and passes the tests.  Tried your test first thing this evening
after git checkout maint and git pull.  I am at 3.4-43-g84d1c3645 which
builds but doesn't pass the tests.  So, I could build turning off the
test step.

However, Friday I was learning more about git bisect to see if I could
figure out which patch caused the tests to start failing.  However, a
couple of items got in the way:  1--time;  2--some commits don't build. 
That messed me up a bit.  So, I may start over again with the bisect
(just for my own edification) and see what happens.  Maybe this time
I'll do a git describe each time and take notes so I'll be a little more
cognizant of what I'm learning.  <<did that make sense>>


--Steve (in the dark)

>
> On Fri., 25 Jan. 2019, 11:52 Stephen M. Butler <[hidden email]
> <mailto:[hidden email]> wrote:
>
>     On 1/24/19 7:36 PM, Christopher Lam wrote:
>     > Revert is a git terminology, not a gnucash one. Welcome to version
>     > control.
>
>     That's the manual to which I referred.  It meant something else to my
>     mind when I first saw your post.  But, after further thought, my
>     previous thought was faulty.
>
>
>     My first boss after college would draw a picture to describe the
>     difference between a bug and a feature.
>
>     I can't draw so a word will have to do (at less than a thousand
>     words)!
>
>     BUG:  draw stick figure.
>
>
>     FEATURE:  Add pants, tie, gloves, shoes and a top hat.
>
>
>     MORAL:  A feature is a bug all dressed up and ready to go out.
>
>     >
>     > Please remember this revert is reverting a buggy code with a
>     previous
>     > buggy code, so, cannot be consisted safe to package; best wait until
>     > the clever devs can find a proper fix for gnc-date.
>     >
>     > On Fri., 25 Jan. 2019, 05:46 Stephen M. Butler <[hidden email]
>     <mailto:[hidden email]>
>     > <mailto:[hidden email] <mailto:[hidden email]>> wrote:
>     >
>     >     OH!  Light bulb on!
>     >     OK.  I understand what you said earlier.  I'll put the patches
>     >     back into
>     >     the packaging.
>     >
>     >     Thanks for clearing that up.
>     >
>     >     --Steve
>     >
>     >     PS Looking in manual for 'revert' command.
>     >
>
>     --
>     Stephen M Butler, PMP, PSM
>     [hidden email] <mailto:[hidden email]>
>     [hidden email] <mailto:[hidden email]>
>     253-350-0166
>     -------------------------------------------
>     GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8
>
>

--
Stephen M Butler, PMP, PSM
[hidden email]
[hidden email]
253-350-0166
-------------------------------------------
GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8


_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] Test failure

Christopher Lam
Thank you Stephen for your results.

It would seem that the test-transaction failure is caused by a faulty
libicu-dev whereas my failure caused by some other issue related to Time
zones.

C

On Sun., 27 Jan. 2019, 09:55 Stephen M. Butler <[hidden email] wrote:

> On 1/26/19 3:13 AM, Christopher Lam wrote:
> > Another experiment. Try prefix your build with "TZ=UTC " on current
> > maint.
> >
> > Eg if using ninja, it'll be "TZ=UTC ninja check"
>
>
> TZ=UTC dpkg- -rfakeroot -b -uc
>
> ....
>
> End testing: Jan 27 01:47 UTC
> + exit 2
> debian/rules:65: recipe for target 'override_dh_auto_test' failed
> make[1]: *** [override_dh_auto_test] Error 2
> make[1]: Leaving directory '/home/steve/Projects/GnuCash/gnucash'
> debian/rules:24: recipe for target 'build' failed
> make: *** [build] Error 2
> dpkg-buildpackage: error: debian/rules build subprocess returned exit
> status 2
>
> Same error -- Test 109 that fails.
>
>
> This is with the patches for 3.4.  I verified before Sabbath that 3.4
> builds and passes the tests.  Tried your test first thing this evening
> after git checkout maint and git pull.  I am at 3.4-43-g84d1c3645 which
> builds but doesn't pass the tests.  So, I could build turning off the
> test step.
>
> However, Friday I was learning more about git bisect to see if I could
> figure out which patch caused the tests to start failing.  However, a
> couple of items got in the way:  1--time;  2--some commits don't build.
> That messed me up a bit.  So, I may start over again with the bisect
> (just for my own edification) and see what happens.  Maybe this time
> I'll do a git describe each time and take notes so I'll be a little more
> cognizant of what I'm learning.  <<did that make sense>>
>
>
> --Steve (in the dark)
>
> >
> > On Fri., 25 Jan. 2019, 11:52 Stephen M. Butler <[hidden email]
> > <mailto:[hidden email]> wrote:
> >
> >     On 1/24/19 7:36 PM, Christopher Lam wrote:
> >     > Revert is a git terminology, not a gnucash one. Welcome to version
> >     > control.
> >
> >     That's the manual to which I referred.  It meant something else to my
> >     mind when I first saw your post.  But, after further thought, my
> >     previous thought was faulty.
> >
> >
> >     My first boss after college would draw a picture to describe the
> >     difference between a bug and a feature.
> >
> >     I can't draw so a word will have to do (at less than a thousand
> >     words)!
> >
> >     BUG:  draw stick figure.
> >
> >
> >     FEATURE:  Add pants, tie, gloves, shoes and a top hat.
> >
> >
> >     MORAL:  A feature is a bug all dressed up and ready to go out.
> >
> >     >
> >     > Please remember this revert is reverting a buggy code with a
> >     previous
> >     > buggy code, so, cannot be consisted safe to package; best wait
> until
> >     > the clever devs can find a proper fix for gnc-date.
> >     >
> >     > On Fri., 25 Jan. 2019, 05:46 Stephen M. Butler <[hidden email]
> >     <mailto:[hidden email]>
> >     > <mailto:[hidden email] <mailto:[hidden email]>> wrote:
> >     >
> >     >     OH!  Light bulb on!
> >     >     OK.  I understand what you said earlier.  I'll put the patches
> >     >     back into
> >     >     the packaging.
> >     >
> >     >     Thanks for clearing that up.
> >     >
> >     >     --Steve
> >     >
> >     >     PS Looking in manual for 'revert' command.
> >     >
> >
> >     --
> >     Stephen M Butler, PMP, PSM
> >     [hidden email] <mailto:[hidden email]>
> >     [hidden email] <mailto:[hidden email]>
> >     253-350-0166
> >     -------------------------------------------
> >     GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8
> >
> >
>
> --
> Stephen M Butler, PMP, PSM
> [hidden email]
> [hidden email]
> 253-350-0166
> -------------------------------------------
> GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8
>
>
>
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] Test failure

John Ralls-2
In reply to this post by Stephen M. Butler
Stephen,

By all means learn about git bisect, it's an extremely useful troubleshooting tool. But don't exercise yourself too much about this particular failure, Chris and I know exactly what commit caused it and that the underlying cause is a bug in ICU (International Components for Unicode, http://site.icu-project.org/) versions 57-62.

I had thought that the problem was confined to 1969, but tonight got https://bugs.gnucash.org/show_bug.cgi?id=797067 which makes me think that it's every year, so more testing needed.

Regards,
John Ralls


> On Jan 26, 2019, at 5:55 PM, Stephen M. Butler <[hidden email]> wrote:
>
> On 1/26/19 3:13 AM, Christopher Lam wrote:
>> Another experiment. Try prefix your build with "TZ=UTC " on current
>> maint.
>>
>> Eg if using ninja, it'll be "TZ=UTC ninja check"
>
>
> TZ=UTC dpkg- -rfakeroot -b -uc
>
> ....
>
> End testing: Jan 27 01:47 UTC
> + exit 2
> debian/rules:65: recipe for target 'override_dh_auto_test' failed
> make[1]: *** [override_dh_auto_test] Error 2
> make[1]: Leaving directory '/home/steve/Projects/GnuCash/gnucash'
> debian/rules:24: recipe for target 'build' failed
> make: *** [build] Error 2
> dpkg-buildpackage: error: debian/rules build subprocess returned exit
> status 2
>
> Same error -- Test 109 that fails.
>
>
> This is with the patches for 3.4.  I verified before Sabbath that 3.4
> builds and passes the tests.  Tried your test first thing this evening
> after git checkout maint and git pull.  I am at 3.4-43-g84d1c3645 which
> builds but doesn't pass the tests.  So, I could build turning off the
> test step.
>
> However, Friday I was learning more about git bisect to see if I could
> figure out which patch caused the tests to start failing.  However, a
> couple of items got in the way:  1--time;  2--some commits don't build.
> That messed me up a bit.  So, I may start over again with the bisect
> (just for my own edification) and see what happens.  Maybe this time
> I'll do a git describe each time and take notes so I'll be a little more
> cognizant of what I'm learning.  <<did that make sense>>
>
>
> --Steve (in the dark)
>
>>
>> On Fri., 25 Jan. 2019, 11:52 Stephen M. Butler <[hidden email]
>> <mailto:[hidden email]> wrote:
>>
>>    On 1/24/19 7:36 PM, Christopher Lam wrote:
>>> Revert is a git terminology, not a gnucash one. Welcome to version
>>> control.
>>
>>    That's the manual to which I referred.  It meant something else to my
>>    mind when I first saw your post.  But, after further thought, my
>>    previous thought was faulty.
>>
>>
>>    My first boss after college would draw a picture to describe the
>>    difference between a bug and a feature.
>>
>>    I can't draw so a word will have to do (at less than a thousand
>>    words)!
>>
>>    BUG:  draw stick figure.
>>
>>
>>    FEATURE:  Add pants, tie, gloves, shoes and a top hat.
>>
>>
>>    MORAL:  A feature is a bug all dressed up and ready to go out.
>>
>>>
>>> Please remember this revert is reverting a buggy code with a
>>    previous
>>> buggy code, so, cannot be consisted safe to package; best wait until
>>> the clever devs can find a proper fix for gnc-date.
>>>
>>> On Fri., 25 Jan. 2019, 05:46 Stephen M. Butler <[hidden email]
>>    <mailto:[hidden email]>
>>> <mailto:[hidden email] <mailto:[hidden email]>> wrote:
>>>
>>>      OH!  Light bulb on!
>>>      OK.  I understand what you said earlier.  I'll put the patches
>>>      back into
>>>      the packaging.
>>>
>>>      Thanks for clearing that up.
>>>
>>>      --Steve
>>>
>>>      PS Looking in manual for 'revert' command.
>>>
>>
>>    --
>>    Stephen M Butler, PMP, PSM
>>    [hidden email] <mailto:[hidden email]>
>>    [hidden email] <mailto:[hidden email]>
>>    253-350-0166
>>    -------------------------------------------
>>    GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8
>>
>>
>
> --
> Stephen M Butler, PMP, PSM
> [hidden email]
> [hidden email]
> 253-350-0166
> -------------------------------------------
> GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8
>
>
> _______________________________________________
> gnucash-devel mailing list
> [hidden email]
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] Test failure

Stephen M. Butler
On 1/26/19 10:29 PM, John Ralls wrote:
> Stephen,
>
> By all means learn about git bisect, it's an extremely useful troubleshooting tool. But don't exercise yourself too much about this particular failure, Chris and I know exactly what commit caused it and that the underlying cause is a bug in ICU (International Components for Unicode, http://site.icu-project.org/) versions 57-62.

I figured the devs were way ahead of me.  And I'm burning the CPU this
evening finding that I can't compile 3.4-21 thru (I'm guessing) 3.4-38. 
I'm up to 3.4-29 at this point and already know that -37 and -38 don't
compile on my box.  But -39, -40, and -43 do.  Don't know about -41 and
-42 (and probably won't check them).

Busy day tomorrow so I doubt the cpu will even get warmed up!  It's
pushing 11 pm so I'll call it quits on this exercise.

Thanks for the details.

--Steve

>
> I had thought that the problem was confined to 1969, but tonight got https://bugs.gnucash.org/show_bug.cgi?id=797067 which makes me think that it's every year, so more testing needed.
>
> Regards,
> John Ralls
>
>
>> On Jan 26, 2019, at 5:55 PM, Stephen M. Butler <[hidden email]> wrote:
>>
>> On 1/26/19 3:13 AM, Christopher Lam wrote:
>>> Another experiment. Try prefix your build with "TZ=UTC " on current
>>> maint.
>>>
>>> Eg if using ninja, it'll be "TZ=UTC ninja check"
>>
>> TZ=UTC dpkg- -rfakeroot -b -uc
>>
>> ....
>>
>> End testing: Jan 27 01:47 UTC
>> + exit 2
>> debian/rules:65: recipe for target 'override_dh_auto_test' failed
>> make[1]: *** [override_dh_auto_test] Error 2
>> make[1]: Leaving directory '/home/steve/Projects/GnuCash/gnucash'
>> debian/rules:24: recipe for target 'build' failed
>> make: *** [build] Error 2
>> dpkg-buildpackage: error: debian/rules build subprocess returned exit
>> status 2
>>
>> Same error -- Test 109 that fails.
>>
>>
>> This is with the patches for 3.4.  I verified before Sabbath that 3.4
>> builds and passes the tests.  Tried your test first thing this evening
>> after git checkout maint and git pull.  I am at 3.4-43-g84d1c3645 which
>> builds but doesn't pass the tests.  So, I could build turning off the
>> test step.
>>
>> However, Friday I was learning more about git bisect to see if I could
>> figure out which patch caused the tests to start failing.  However, a
>> couple of items got in the way:  1--time;  2--some commits don't build.
>> That messed me up a bit.  So, I may start over again with the bisect
>> (just for my own edification) and see what happens.  Maybe this time
>> I'll do a git describe each time and take notes so I'll be a little more
>> cognizant of what I'm learning.  <<did that make sense>>
>>
>>
>> --Steve (in the dark)
>>
>>> On Fri., 25 Jan. 2019, 11:52 Stephen M. Butler <[hidden email]
>>> <mailto:[hidden email]> wrote:
>>>
>>>    On 1/24/19 7:36 PM, Christopher Lam wrote:
>>>> Revert is a git terminology, not a gnucash one. Welcome to version
>>>> control.
>>>    That's the manual to which I referred.  It meant something else to my
>>>    mind when I first saw your post.  But, after further thought, my
>>>    previous thought was faulty.
>>>
>>>
>>>    My first boss after college would draw a picture to describe the
>>>    difference between a bug and a feature.
>>>
>>>    I can't draw so a word will have to do (at less than a thousand
>>>    words)!
>>>
>>>    BUG:  draw stick figure.
>>>
>>>
>>>    FEATURE:  Add pants, tie, gloves, shoes and a top hat.
>>>
>>>
>>>    MORAL:  A feature is a bug all dressed up and ready to go out.
>>>
>>>> Please remember this revert is reverting a buggy code with a
>>>    previous
>>>> buggy code, so, cannot be consisted safe to package; best wait until
>>>> the clever devs can find a proper fix for gnc-date.
>>>>
>>>> On Fri., 25 Jan. 2019, 05:46 Stephen M. Butler <[hidden email]
>>>    <mailto:[hidden email]>
>>>> <mailto:[hidden email] <mailto:[hidden email]>> wrote:
>>>>
>>>>      OH!  Light bulb on!
>>>>      OK.  I understand what you said earlier.  I'll put the patches
>>>>      back into
>>>>      the packaging.
>>>>
>>>>      Thanks for clearing that up.
>>>>
>>>>      --Steve
>>>>
>>>>      PS Looking in manual for 'revert' command.
>>>>
>>>    --
>>>    Stephen M Butler, PMP, PSM
>>>    [hidden email] <mailto:[hidden email]>
>>>    [hidden email] <mailto:[hidden email]>
>>>    253-350-0166
>>>    -------------------------------------------
>>>    GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8
>>>
>>>
>> --
>> Stephen M Butler, PMP, PSM
>> [hidden email]
>> [hidden email]
>> 253-350-0166
>> -------------------------------------------
>> GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8
>>
>>
>> _______________________________________________
>> gnucash-devel mailing list
>> [hidden email]
>> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>

--
Stephen M Butler, PMP, PSM
[hidden email]
[hidden email]
253-350-0166
-------------------------------------------
GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8


_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] Test failure

Christopher Lam
Stephen please spend some CPU burning time on my chartJS branch which
needs beta testing?

$git clone
https://github.com/christopherlam/gnucash/tree/maint-chartjs-budget-barchart


On 27/1/19 2:52 pm, Stephen M. Butler wrote:

> On 1/26/19 10:29 PM, John Ralls wrote:
>> Stephen,
>>
>> By all means learn about git bisect, it's an extremely useful troubleshooting tool. But don't exercise yourself too much about this particular failure, Chris and I know exactly what commit caused it and that the underlying cause is a bug in ICU (International Components for Unicode, http://site.icu-project.org/) versions 57-62.
> I figured the devs were way ahead of me.  And I'm burning the CPU this
> evening finding that I can't compile 3.4-21 thru (I'm guessing) 3.4-38.
> I'm up to 3.4-29 at this point and already know that -37 and -38 don't
> compile on my box.  But -39, -40, and -43 do.  Don't know about -41 and
> -42 (and probably won't check them).
>
> Busy day tomorrow so I doubt the cpu will even get warmed up!  It's
> pushing 11 pm so I'll call it quits on this exercise.
>
> Thanks for the details.
>
> --Steve
>
>> I had thought that the problem was confined to 1969, but tonight got https://bugs.gnucash.org/show_bug.cgi?id=797067 which makes me think that it's every year, so more testing needed.
>>
>> Regards,
>> John Ralls
>>
>>
>>> On Jan 26, 2019, at 5:55 PM, Stephen M. Butler <[hidden email]> wrote:
>>>
>>> On 1/26/19 3:13 AM, Christopher Lam wrote:
>>>> Another experiment. Try prefix your build with "TZ=UTC " on current
>>>> maint.
>>>>
>>>> Eg if using ninja, it'll be "TZ=UTC ninja check"
>>> TZ=UTC dpkg- -rfakeroot -b -uc
>>>
>>> ....
>>>
>>> End testing: Jan 27 01:47 UTC
>>> + exit 2
>>> debian/rules:65: recipe for target 'override_dh_auto_test' failed
>>> make[1]: *** [override_dh_auto_test] Error 2
>>> make[1]: Leaving directory '/home/steve/Projects/GnuCash/gnucash'
>>> debian/rules:24: recipe for target 'build' failed
>>> make: *** [build] Error 2
>>> dpkg-buildpackage: error: debian/rules build subprocess returned exit
>>> status 2
>>>
>>> Same error -- Test 109 that fails.
>>>
>>>
>>> This is with the patches for 3.4.  I verified before Sabbath that 3.4
>>> builds and passes the tests.  Tried your test first thing this evening
>>> after git checkout maint and git pull.  I am at 3.4-43-g84d1c3645 which
>>> builds but doesn't pass the tests.  So, I could build turning off the
>>> test step.
>>>
>>> However, Friday I was learning more about git bisect to see if I could
>>> figure out which patch caused the tests to start failing.  However, a
>>> couple of items got in the way:  1--time;  2--some commits don't build.
>>> That messed me up a bit.  So, I may start over again with the bisect
>>> (just for my own edification) and see what happens.  Maybe this time
>>> I'll do a git describe each time and take notes so I'll be a little more
>>> cognizant of what I'm learning.  <<did that make sense>>
>>>
>>>
>>> --Steve (in the dark)
>>>
>>>> On Fri., 25 Jan. 2019, 11:52 Stephen M. Butler <[hidden email]
>>>> <mailto:[hidden email]> wrote:
>>>>
>>>>     On 1/24/19 7:36 PM, Christopher Lam wrote:
>>>>> Revert is a git terminology, not a gnucash one. Welcome to version
>>>>> control.
>>>>     That's the manual to which I referred.  It meant something else to my
>>>>     mind when I first saw your post.  But, after further thought, my
>>>>     previous thought was faulty.
>>>>
>>>>
>>>>     My first boss after college would draw a picture to describe the
>>>>     difference between a bug and a feature.
>>>>
>>>>     I can't draw so a word will have to do (at less than a thousand
>>>>     words)!
>>>>
>>>>     BUG:  draw stick figure.
>>>>
>>>>
>>>>     FEATURE:  Add pants, tie, gloves, shoes and a top hat.
>>>>
>>>>
>>>>     MORAL:  A feature is a bug all dressed up and ready to go out.
>>>>
>>>>> Please remember this revert is reverting a buggy code with a
>>>>     previous
>>>>> buggy code, so, cannot be consisted safe to package; best wait until
>>>>> the clever devs can find a proper fix for gnc-date.
>>>>>
>>>>> On Fri., 25 Jan. 2019, 05:46 Stephen M. Butler <[hidden email]
>>>>     <mailto:[hidden email]>
>>>>> <mailto:[hidden email] <mailto:[hidden email]>> wrote:
>>>>>
>>>>>       OH!  Light bulb on!
>>>>>       OK.  I understand what you said earlier.  I'll put the patches
>>>>>       back into
>>>>>       the packaging.
>>>>>
>>>>>       Thanks for clearing that up.
>>>>>
>>>>>       --Steve
>>>>>
>>>>>       PS Looking in manual for 'revert' command.
>>>>>
>>>>     --
>>>>     Stephen M Butler, PMP, PSM
>>>>     [hidden email] <mailto:[hidden email]>
>>>>     [hidden email] <mailto:[hidden email]>
>>>>     253-350-0166
>>>>     -------------------------------------------
>>>>     GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8
>>>>
>>>>
>>> --
>>> Stephen M Butler, PMP, PSM
>>> [hidden email]
>>> [hidden email]
>>> 253-350-0166
>>> -------------------------------------------
>>> GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8
>>>
>>>
>>> _______________________________________________
>>> gnucash-devel mailing list
>>> [hidden email]
>>> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] Test failure

Stephen M. Butler
On 1/26/19 10:54 PM, Christopher Lam wrote:
> Stephen please spend some CPU burning time on my chartJS branch which
> needs beta testing?
>
> $git clone
> https://github.com/christopherlam/gnucash/tree/maint-chartjs-budget-barchart


Thought I'd start this while headed toward some z's.  Too tired to
figure out what happened.

 git clone
https://github.com/christopherlam/gnucash/tree/maint-chartjs-budget-barchart
Cloning into 'maint-chartjs-budget-barchart'...
fatal: repository
'https://github.com/christopherlam/gnucash/tree/maint-chartjs-budget-barchart/'
not found


--Steve

>
>
> On 27/1/19 2:52 pm, Stephen M. Butler wrote:
>> On 1/26/19 10:29 PM, John Ralls wrote:
>>> Stephen,
>>>
>>> By all means learn about git bisect, it's an extremely useful
>>> troubleshooting tool. But don't exercise yourself too much about
>>> this particular failure, Chris and I know exactly what commit caused
>>> it and that the underlying cause is a bug in ICU (International
>>> Components for Unicode, http://site.icu-project.org/) versions 57-62.
>> I figured the devs were way ahead of me.  And I'm burning the CPU this
>> evening finding that I can't compile 3.4-21 thru (I'm guessing) 3.4-38.
>> I'm up to 3.4-29 at this point and already know that -37 and -38 don't
>> compile on my box.  But -39, -40, and -43 do.  Don't know about -41 and
>> -42 (and probably won't check them).
>>
>> Busy day tomorrow so I doubt the cpu will even get warmed up!  It's
>> pushing 11 pm so I'll call it quits on this exercise.
>>
>> Thanks for the details.
>>
>> --Steve
>>
>>> I had thought that the problem was confined to 1969, but tonight got
>>> https://bugs.gnucash.org/show_bug.cgi?id=797067 which makes me think
>>> that it's every year, so more testing needed.
>>>
>>> Regards,
>>> John Ralls
>>>
>>>
>>>> On Jan 26, 2019, at 5:55 PM, Stephen M. Butler <[hidden email]> wrote:
>>>>
>>>> On 1/26/19 3:13 AM, Christopher Lam wrote:
>>>>> Another experiment. Try prefix your build with "TZ=UTC " on current
>>>>> maint.
>>>>>
>>>>> Eg if using ninja, it'll be "TZ=UTC ninja check"
>>>> TZ=UTC dpkg- -rfakeroot -b -uc
>>>>
>>>> ....
>>>>
>>>> End testing: Jan 27 01:47 UTC
>>>> + exit 2
>>>> debian/rules:65: recipe for target 'override_dh_auto_test' failed
>>>> make[1]: *** [override_dh_auto_test] Error 2
>>>> make[1]: Leaving directory '/home/steve/Projects/GnuCash/gnucash'
>>>> debian/rules:24: recipe for target 'build' failed
>>>> make: *** [build] Error 2
>>>> dpkg-buildpackage: error: debian/rules build subprocess returned exit
>>>> status 2
>>>>
>>>> Same error -- Test 109 that fails.
>>>>
>>>>
>>>> This is with the patches for 3.4.  I verified before Sabbath that 3.4
>>>> builds and passes the tests.  Tried your test first thing this evening
>>>> after git checkout maint and git pull.  I am at 3.4-43-g84d1c3645
>>>> which
>>>> builds but doesn't pass the tests.  So, I could build turning off the
>>>> test step.
>>>>
>>>> However, Friday I was learning more about git bisect to see if I could
>>>> figure out which patch caused the tests to start failing.  However, a
>>>> couple of items got in the way:  1--time;  2--some commits don't
>>>> build.
>>>> That messed me up a bit.  So, I may start over again with the bisect
>>>> (just for my own edification) and see what happens.  Maybe this time
>>>> I'll do a git describe each time and take notes so I'll be a little
>>>> more
>>>> cognizant of what I'm learning.  <<did that make sense>>
>>>>
>>>>
>>>> --Steve (in the dark)
>>>>
>>>>> On Fri., 25 Jan. 2019, 11:52 Stephen M. Butler <[hidden email]
>>>>> <mailto:[hidden email]> wrote:
>>>>>
>>>>>     On 1/24/19 7:36 PM, Christopher Lam wrote:
>>>>>> Revert is a git terminology, not a gnucash one. Welcome to version
>>>>>> control.
>>>>>     That's the manual to which I referred.  It meant something
>>>>> else to my
>>>>>     mind when I first saw your post.  But, after further thought, my
>>>>>     previous thought was faulty.
>>>>>
>>>>>
>>>>>     My first boss after college would draw a picture to describe the
>>>>>     difference between a bug and a feature.
>>>>>
>>>>>     I can't draw so a word will have to do (at less than a thousand
>>>>>     words)!
>>>>>
>>>>>     BUG:  draw stick figure.
>>>>>
>>>>>
>>>>>     FEATURE:  Add pants, tie, gloves, shoes and a top hat.
>>>>>
>>>>>
>>>>>     MORAL:  A feature is a bug all dressed up and ready to go out.
>>>>>
>>>>>> Please remember this revert is reverting a buggy code with a
>>>>>     previous
>>>>>> buggy code, so, cannot be consisted safe to package; best wait until
>>>>>> the clever devs can find a proper fix for gnc-date.
>>>>>>
>>>>>> On Fri., 25 Jan. 2019, 05:46 Stephen M. Butler <[hidden email]
>>>>>     <mailto:[hidden email]>
>>>>>> <mailto:[hidden email] <mailto:[hidden email]>> wrote:
>>>>>>
>>>>>>       OH!  Light bulb on!
>>>>>>       OK.  I understand what you said earlier.  I'll put the patches
>>>>>>       back into
>>>>>>       the packaging.
>>>>>>
>>>>>>       Thanks for clearing that up.
>>>>>>
>>>>>>       --Steve
>>>>>>
>>>>>>       PS Looking in manual for 'revert' command.
>

--
Stephen M Butler, PMP, PSM
[hidden email]
[hidden email]
253-350-0166
-------------------------------------------
GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] Test failure

Christopher Lam
Ok my bad

May be safer to reuse your own gnucash repository

  * cd gnucash
  * git remote add chris https://github.com/christopherlam/gnucash.git
  * git fetch --all
  * git checkout chris/maint-chartjs-budget-barchart
  * dpkg etc

and to revert to main branch:

  * git checkout maint



On 27/1/19 3:04 pm, Stephen M. Butler wrote:

> On 1/26/19 10:54 PM, Christopher Lam wrote:
>> Stephen please spend some CPU burning time on my chartJS branch which
>> needs beta testing?
>>
>> $git clone
>> https://github.com/christopherlam/gnucash/tree/maint-chartjs-budget-barchart
>
> Thought I'd start this while headed toward some z's.  Too tired to
> figure out what happened.
>
>   git clone
> https://github.com/christopherlam/gnucash/tree/maint-chartjs-budget-barchart
> Cloning into 'maint-chartjs-budget-barchart'...
> fatal: repository
> 'https://github.com/christopherlam/gnucash/tree/maint-chartjs-budget-barchart/'
> not found
>
>
> --Steve
>
>>
>> On 27/1/19 2:52 pm, Stephen M. Butler wrote:
>>> On 1/26/19 10:29 PM, John Ralls wrote:
>>>> Stephen,
>>>>
>>>> By all means learn about git bisect, it's an extremely useful
>>>> troubleshooting tool. But don't exercise yourself too much about
>>>> this particular failure, Chris and I know exactly what commit caused
>>>> it and that the underlying cause is a bug in ICU (International
>>>> Components for Unicode, http://site.icu-project.org/) versions 57-62.
>>> I figured the devs were way ahead of me.  And I'm burning the CPU this
>>> evening finding that I can't compile 3.4-21 thru (I'm guessing) 3.4-38.
>>> I'm up to 3.4-29 at this point and already know that -37 and -38 don't
>>> compile on my box.  But -39, -40, and -43 do.  Don't know about -41 and
>>> -42 (and probably won't check them).
>>>
>>> Busy day tomorrow so I doubt the cpu will even get warmed up!  It's
>>> pushing 11 pm so I'll call it quits on this exercise.
>>>
>>> Thanks for the details.
>>>
>>> --Steve
>>>
>>>> I had thought that the problem was confined to 1969, but tonight got
>>>> https://bugs.gnucash.org/show_bug.cgi?id=797067 which makes me think
>>>> that it's every year, so more testing needed.
>>>>
>>>> Regards,
>>>> John Ralls
>>>>
>>>>
>>>>> On Jan 26, 2019, at 5:55 PM, Stephen M. Butler <[hidden email]> wrote:
>>>>>
>>>>> On 1/26/19 3:13 AM, Christopher Lam wrote:
>>>>>> Another experiment. Try prefix your build with "TZ=UTC " on current
>>>>>> maint.
>>>>>>
>>>>>> Eg if using ninja, it'll be "TZ=UTC ninja check"
>>>>> TZ=UTC dpkg- -rfakeroot -b -uc
>>>>>
>>>>> ....
>>>>>
>>>>> End testing: Jan 27 01:47 UTC
>>>>> + exit 2
>>>>> debian/rules:65: recipe for target 'override_dh_auto_test' failed
>>>>> make[1]: *** [override_dh_auto_test] Error 2
>>>>> make[1]: Leaving directory '/home/steve/Projects/GnuCash/gnucash'
>>>>> debian/rules:24: recipe for target 'build' failed
>>>>> make: *** [build] Error 2
>>>>> dpkg-buildpackage: error: debian/rules build subprocess returned exit
>>>>> status 2
>>>>>
>>>>> Same error -- Test 109 that fails.
>>>>>
>>>>>
>>>>> This is with the patches for 3.4.  I verified before Sabbath that 3.4
>>>>> builds and passes the tests.  Tried your test first thing this evening
>>>>> after git checkout maint and git pull.  I am at 3.4-43-g84d1c3645
>>>>> which
>>>>> builds but doesn't pass the tests.  So, I could build turning off the
>>>>> test step.
>>>>>
>>>>> However, Friday I was learning more about git bisect to see if I could
>>>>> figure out which patch caused the tests to start failing.  However, a
>>>>> couple of items got in the way:  1--time;  2--some commits don't
>>>>> build.
>>>>> That messed me up a bit.  So, I may start over again with the bisect
>>>>> (just for my own edification) and see what happens.  Maybe this time
>>>>> I'll do a git describe each time and take notes so I'll be a little
>>>>> more
>>>>> cognizant of what I'm learning.  <<did that make sense>>
>>>>>
>>>>>
>>>>> --Steve (in the dark)
>>>>>
>>>>>> On Fri., 25 Jan. 2019, 11:52 Stephen M. Butler <[hidden email]
>>>>>> <mailto:[hidden email]> wrote:
>>>>>>
>>>>>>      On 1/24/19 7:36 PM, Christopher Lam wrote:
>>>>>>> Revert is a git terminology, not a gnucash one. Welcome to version
>>>>>>> control.
>>>>>>      That's the manual to which I referred.  It meant something
>>>>>> else to my
>>>>>>      mind when I first saw your post.  But, after further thought, my
>>>>>>      previous thought was faulty.
>>>>>>
>>>>>>
>>>>>>      My first boss after college would draw a picture to describe the
>>>>>>      difference between a bug and a feature.
>>>>>>
>>>>>>      I can't draw so a word will have to do (at less than a thousand
>>>>>>      words)!
>>>>>>
>>>>>>      BUG:  draw stick figure.
>>>>>>
>>>>>>
>>>>>>      FEATURE:  Add pants, tie, gloves, shoes and a top hat.
>>>>>>
>>>>>>
>>>>>>      MORAL:  A feature is a bug all dressed up and ready to go out.
>>>>>>
>>>>>>> Please remember this revert is reverting a buggy code with a
>>>>>>      previous
>>>>>>> buggy code, so, cannot be consisted safe to package; best wait until
>>>>>>> the clever devs can find a proper fix for gnc-date.
>>>>>>>
>>>>>>> On Fri., 25 Jan. 2019, 05:46 Stephen M. Butler <[hidden email]
>>>>>>      <mailto:[hidden email]>
>>>>>>> <mailto:[hidden email] <mailto:[hidden email]>> wrote:
>>>>>>>
>>>>>>>        OH!  Light bulb on!
>>>>>>>        OK.  I understand what you said earlier.  I'll put the patches
>>>>>>>        back into
>>>>>>>        the packaging.
>>>>>>>
>>>>>>>        Thanks for clearing that up.
>>>>>>>
>>>>>>>        --Steve
>>>>>>>
>>>>>>>        PS Looking in manual for 'revert' command.
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] Test failure

John Ralls-2
You can do it that way or you can do

git clone https://github.com/christopherlam/gnucash.git -b maint-chartjs-budget-barchart/

or

git clone https://github.com/christopherlam/gnucash.git
git checkout  -b maint-chartjs-budget-barchart/

or the way we do for testing pull requests; this is a bit fiddly because of the possible merge commit and conflicts, but it doesn't permanently add a remote:

git checkout -b maint-chartjs-budget-barchart maint
git pull https://github.com/christopherlam/gnucash.git maint-chartjs-budget-barchart/

You can get a fast-forward if you go to https://github.com/christopherlam/gnucash/tree/maint-chartjs-budget-barchart, click the "20,557 Commits", and scroll down to find the first commit by someone else, in this case it's f9f714c. Use that instead of maint as the last argument to git checkout.

You can't clone a GitHub tree URL, that's not a repository.

Regards,
John Ralls

> On Jan 26, 2019, at 11:20 PM, Christopher Lam <[hidden email]> wrote:
>
> Ok my bad
>
> May be safer to reuse your own gnucash repository
>
> * cd gnucash
> * git remote add chris https://github.com/christopherlam/gnucash.git
> * git fetch --all
> * git checkout chris/maint-chartjs-budget-barchart
> * dpkg etc
>
> and to revert to main branch:
>
> * git checkout maint
>
>
>
> On 27/1/19 3:04 pm, Stephen M. Butler wrote:
>> On 1/26/19 10:54 PM, Christopher Lam wrote:
>>> Stephen please spend some CPU burning time on my chartJS branch which
>>> needs beta testing?
>>>
>>> $git clone
>>> https://github.com/christopherlam/gnucash/tree/maint-chartjs-budget-barchart
>>
>> Thought I'd start this while headed toward some z's.  Too tired to
>> figure out what happened.
>>
>>  git clone
>> https://github.com/christopherlam/gnucash/tree/maint-chartjs-budget-barchart
>> Cloning into 'maint-chartjs-budget-barchart'...
>> fatal: repository
>> 'https://github.com/christopherlam/gnucash/tree/maint-chartjs-budget-barchart/'
>> not found
>>
>>
>> --Steve
>>
>>>
>>> On 27/1/19 2:52 pm, Stephen M. Butler wrote:
>>>> On 1/26/19 10:29 PM, John Ralls wrote:
>>>>> Stephen,
>>>>>
>>>>> By all means learn about git bisect, it's an extremely useful
>>>>> troubleshooting tool. But don't exercise yourself too much about
>>>>> this particular failure, Chris and I know exactly what commit caused
>>>>> it and that the underlying cause is a bug in ICU (International
>>>>> Components for Unicode, http://site.icu-project.org/) versions 57-62.
>>>> I figured the devs were way ahead of me.  And I'm burning the CPU this
>>>> evening finding that I can't compile 3.4-21 thru (I'm guessing) 3.4-38.
>>>> I'm up to 3.4-29 at this point and already know that -37 and -38 don't
>>>> compile on my box.  But -39, -40, and -43 do.  Don't know about -41 and
>>>> -42 (and probably won't check them).
>>>>
>>>> Busy day tomorrow so I doubt the cpu will even get warmed up!  It's
>>>> pushing 11 pm so I'll call it quits on this exercise.
>>>>
>>>> Thanks for the details.
>>>>
>>>> --Steve
>>>>
>>>>> I had thought that the problem was confined to 1969, but tonight got
>>>>> https://bugs.gnucash.org/show_bug.cgi?id=797067 which makes me think
>>>>> that it's every year, so more testing needed.
>>>>>
>>>>> Regards,
>>>>> John Ralls
>>>>>
>>>>>
>>>>>> On Jan 26, 2019, at 5:55 PM, Stephen M. Butler <[hidden email]> wrote:
>>>>>>
>>>>>> On 1/26/19 3:13 AM, Christopher Lam wrote:
>>>>>>> Another experiment. Try prefix your build with "TZ=UTC " on current
>>>>>>> maint.
>>>>>>>
>>>>>>> Eg if using ninja, it'll be "TZ=UTC ninja check"
>>>>>> TZ=UTC dpkg- -rfakeroot -b -uc
>>>>>>
>>>>>> ....
>>>>>>
>>>>>> End testing: Jan 27 01:47 UTC
>>>>>> + exit 2
>>>>>> debian/rules:65: recipe for target 'override_dh_auto_test' failed
>>>>>> make[1]: *** [override_dh_auto_test] Error 2
>>>>>> make[1]: Leaving directory '/home/steve/Projects/GnuCash/gnucash'
>>>>>> debian/rules:24: recipe for target 'build' failed
>>>>>> make: *** [build] Error 2
>>>>>> dpkg-buildpackage: error: debian/rules build subprocess returned exit
>>>>>> status 2
>>>>>>
>>>>>> Same error -- Test 109 that fails.
>>>>>>
>>>>>>
>>>>>> This is with the patches for 3.4.  I verified before Sabbath that 3.4
>>>>>> builds and passes the tests.  Tried your test first thing this evening
>>>>>> after git checkout maint and git pull.  I am at 3.4-43-g84d1c3645
>>>>>> which
>>>>>> builds but doesn't pass the tests.  So, I could build turning off the
>>>>>> test step.
>>>>>>
>>>>>> However, Friday I was learning more about git bisect to see if I could
>>>>>> figure out which patch caused the tests to start failing.  However, a
>>>>>> couple of items got in the way:  1--time;  2--some commits don't
>>>>>> build.
>>>>>> That messed me up a bit.  So, I may start over again with the bisect
>>>>>> (just for my own edification) and see what happens.  Maybe this time
>>>>>> I'll do a git describe each time and take notes so I'll be a little
>>>>>> more
>>>>>> cognizant of what I'm learning.  <<did that make sense>>
>>>>>>
>>>>>>
>>>>>> --Steve (in the dark)
>>>>>>
>>>>>>> On Fri., 25 Jan. 2019, 11:52 Stephen M. Butler <[hidden email]
>>>>>>> <mailto:[hidden email]> wrote:
>>>>>>>
>>>>>>>     On 1/24/19 7:36 PM, Christopher Lam wrote:
>>>>>>>> Revert is a git terminology, not a gnucash one. Welcome to version
>>>>>>>> control.
>>>>>>>     That's the manual to which I referred.  It meant something
>>>>>>> else to my
>>>>>>>     mind when I first saw your post.  But, after further thought, my
>>>>>>>     previous thought was faulty.
>>>>>>>
>>>>>>>
>>>>>>>     My first boss after college would draw a picture to describe the
>>>>>>>     difference between a bug and a feature.
>>>>>>>
>>>>>>>     I can't draw so a word will have to do (at less than a thousand
>>>>>>>     words)!
>>>>>>>
>>>>>>>     BUG:  draw stick figure.
>>>>>>>
>>>>>>>
>>>>>>>     FEATURE:  Add pants, tie, gloves, shoes and a top hat.
>>>>>>>
>>>>>>>
>>>>>>>     MORAL:  A feature is a bug all dressed up and ready to go out.
>>>>>>>
>>>>>>>> Please remember this revert is reverting a buggy code with a
>>>>>>>     previous
>>>>>>>> buggy code, so, cannot be consisted safe to package; best wait until
>>>>>>>> the clever devs can find a proper fix for gnc-date.
>>>>>>>>
>>>>>>>> On Fri., 25 Jan. 2019, 05:46 Stephen M. Butler <[hidden email]
>>>>>>>     <mailto:[hidden email]>
>>>>>>>> <mailto:[hidden email] <mailto:[hidden email]>> wrote:
>>>>>>>>
>>>>>>>>       OH!  Light bulb on!
>>>>>>>>       OK.  I understand what you said earlier.  I'll put the patches
>>>>>>>>       back into
>>>>>>>>       the packaging.
>>>>>>>>
>>>>>>>>       Thanks for clearing that up.
>>>>>>>>
>>>>>>>>       --Steve
>>>>>>>>
>>>>>>>>       PS Looking in manual for 'revert' command.
> _______________________________________________
> gnucash-devel mailing list
> [hidden email]
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] Test failure

Stephen M. Butler
In reply to this post by Christopher Lam
On 1/26/19 11:20 PM, Christopher Lam wrote:

>
> Ok my bad
>
> May be safer to reuse your own gnucash repository
>
>   * cd gnucash
>   * git remote add chris https://github.com/christopherlam/gnucash.git
>   * git fetch --all
>   * git checkout chris/maint-chartjs-budget-barchart
>   * dpkg etc
>
> and to revert to main branch:
>
>   * git checkout maint
>
>
Just a quick note before running out the door for the day.  It compiled
and passed test 109 (with the 3.4 build patch in place).  I'm presuming
you don't have the broken patch in this branch.


--Steve

PS  Saw the note from John and decided that was a 400 series course. 
Options -- too many options. 

>
> On 27/1/19 3:04 pm, Stephen M. Butler wrote:
>> On 1/26/19 10:54 PM, Christopher Lam wrote:
>>> Stephen please spend some CPU burning time on my chartJS branch which
>>> needs beta testing?
>>>
>>> $git clone
>>> https://github.com/christopherlam/gnucash/tree/maint-chartjs-budget-barchart
>> Thought I'd start this while headed toward some z's.  Too tired to
>> figure out what happened.
>>
>>  git clone
>> https://github.com/christopherlam/gnucash/tree/maint-chartjs-budget-barchart
>> Cloning into 'maint-chartjs-budget-barchart'...
>> fatal: repository
>> 'https://github.com/christopherlam/gnucash/tree/maint-chartjs-budget-barchart/'
>> not found
>>
>>
>> --Steve
>>
>>> On 27/1/19 2:52 pm, Stephen M. Butler wrote:
>>>> On 1/26/19 10:29 PM, John Ralls wrote:
>>>>> Stephen,
>>>>>
>>>>> By all means learn about git bisect, it's an extremely useful
>>>>> troubleshooting tool. But don't exercise yourself too much about
>>>>> this particular failure, Chris and I know exactly what commit caused
>>>>> it and that the underlying cause is a bug in ICU (International
>>>>> Components for Unicode, http://site.icu-project.org/) versions 57-62.
>>>> I figured the devs were way ahead of me.  And I'm burning the CPU this
>>>> evening finding that I can't compile 3.4-21 thru (I'm guessing) 3.4-38.
>>>> I'm up to 3.4-29 at this point and already know that -37 and -38 don't
>>>> compile on my box.  But -39, -40, and -43 do.  Don't know about -41 and
>>>> -42 (and probably won't check them).
>>>>
>>>> Busy day tomorrow so I doubt the cpu will even get warmed up!  It's
>>>> pushing 11 pm so I'll call it quits on this exercise.
>>>>
>>>> Thanks for the details.
>>>>
>>>> --Steve
>>>>
>>>>> I had thought that the problem was confined to 1969, but tonight got
>>>>> https://bugs.gnucash.org/show_bug.cgi?id=797067 which makes me think
>>>>> that it's every year, so more testing needed.
>>>>>
>>>>> Regards,
>>>>> John Ralls

--
Stephen M Butler, PMP, PSM
[hidden email]
[hidden email]
253-350-0166
-------------------------------------------
GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel