[GNC-dev] Removing gncmod-python.c in commit 4ecd9c2dd41ae75ec4e82a662a241543fc075c01

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GNC-dev] Removing gncmod-python.c in commit 4ecd9c2dd41ae75ec4e82a662a241543fc075c01

David Osguthorpe
Hi,

Would a patch to restore gncmod-python.c be accepted for inclusion.

I have been using this to load a python subsystem into gnucash for a
number of years.

I know it cant be restored as was but I have a small patch to it which
removes the calls to the init of the _sw_core_utils and _sw_app_utils
modules in the code (which dont appear to be used directly in
gncmod-python.c). This means gncmod-python.dylib simply links to
gnc-core-utils and no need for gnc-core-utils-python
gncmod-app-utils-python.

With this patch - and some python 3 fixups to init.py the init.py has
no errors on loading.

Note that gncmod-python.c was only place the init.py script was used.

Thanks

David Osguthorpe
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] Removing gncmod-python.c in commit 4ecd9c2dd41ae75ec4e82a662a241543fc075c01

John Ralls-2


> On Jul 3, 2018, at 9:11 AM, David Osguthorpe <[hidden email]> wrote:
>
> Hi,
>
> Would a patch to restore gncmod-python.c be accepted for inclusion.
>
> I have been using this to load a python subsystem into gnucash for a
> number of years.
>
> I know it cant be restored as was but I have a small patch to it which
> removes the calls to the init of the _sw_core_utils and _sw_app_utils
> modules in the code (which dont appear to be used directly in
> gncmod-python.c). This means gncmod-python.dylib simply links to
> gnc-core-utils and no need for gnc-core-utils-python
> gncmod-app-utils-python.
>
> With this patch - and some python 3 fixups to init.py the init.py has
> no errors on loading.
>
> Note that gncmod-python.c was only place the init.py script was used.

David,

So there actually is someone using that! Sure, go ahead.

The _sw_core_utils and _sw_app_utils calls would have been to make those modules' API available for import into the python console, but it might be cleaner if the python console could import the python bindings instead.

Please also remove the files in pycons that aren't needed and don't work with Gtk3 (pycons in particular is using pygtk and pypango instead of pygobject).

Regards,
John Ralls

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GNC-dev] Removing gncmod-python.c in commit 4ecd9c2dd41ae75ec4e82a662a241543fc075c01

David Osguthorpe
Thanks for the response.

I have now managed to update my python subsystem so all seems to be
working as before now with Gtk3
and gnucash 3.2. (Switching to Gtk3 is good as now also means can use
python 3 for pygtk - gnucash was
main system I was still at python2.7).

For some reason gmail dumped this in its spam!

Will add the patch.

David

On Tue, Jul 3, 2018 at 6:21 PM, John Ralls <[hidden email]> wrote:

>
>
>> On Jul 3, 2018, at 9:11 AM, David Osguthorpe <[hidden email]> wrote:
>>
>> Hi,
>>
>> Would a patch to restore gncmod-python.c be accepted for inclusion.
>>
>> I have been using this to load a python subsystem into gnucash for a
>> number of years.
>>
>> I know it cant be restored as was but I have a small patch to it which
>> removes the calls to the init of the _sw_core_utils and _sw_app_utils
>> modules in the code (which dont appear to be used directly in
>> gncmod-python.c). This means gncmod-python.dylib simply links to
>> gnc-core-utils and no need for gnc-core-utils-python
>> gncmod-app-utils-python.
>>
>> With this patch - and some python 3 fixups to init.py the init.py has
>> no errors on loading.
>>
>> Note that gncmod-python.c was only place the init.py script was used.
>
> David,
>
> So there actually is someone using that! Sure, go ahead.
>
> The _sw_core_utils and _sw_app_utils calls would have been to make those modules' API available for import into the python console, but it might be cleaner if the python console could import the python bindings instead.
>
> Please also remove the files in pycons that aren't needed and don't work with Gtk3 (pycons in particular is using pygtk and pypango instead of pygobject).
>
> Regards,
> John Ralls
>
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel