Convert the default currency preferences over to gconf.

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Convert the default currency preferences over to gconf.

David Hampton
Log Message:
-----------
Convert the default currency preferences over to gconf.

Tags:
----
gnucash-gnome2-dev

Modified Files:
--------------
    gnucash:
        ChangeLog
    gnucash/src/app-utils:
        global-options.c
        prefs.scm
    gnucash/src/gnome/schemas:
        apps_gnucash_general.schemas
    gnucash/src/gnome-utils:
        dialog-preferences.c
        preferences.glade
_______________________________________________
gnucash-patches mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-patches
Reply | Threaded
Open this post in threaded view
|

Re: Convert the default currency preferences over to gconf.

Didier Vidal
I had to make this patch locally to avoid a crash with gnucash:

[vidal@oscar3 app-utils]$ cvs diff *.c
Index: global-options.c
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/src/app-utils/global-options.c,v
retrieving revision 1.6.4.4
diff -r1.6.4.4 global-options.c
398c398
<   if (strcmp(choice, "other") == 0) {
---
>   if (choice && strcmp(choice, "other") == 0) {
421c421
<   if (strcmp(choice, "other") == 0) {
---
>   if (choice && strcmp(choice, "other") == 0) {



Le sam 24/09/2005 à 22:28, David Hampton a écrit :

> Log Message:
> -----------
> Convert the default currency preferences over to gconf.
>
> Tags:
> ----
> gnucash-gnome2-dev
>
> Modified Files:
> --------------
>     gnucash:
>         ChangeLog
>     gnucash/src/app-utils:
>         global-options.c
>         prefs.scm
>     gnucash/src/gnome/schemas:
>         apps_gnucash_general.schemas
>     gnucash/src/gnome-utils:
>         dialog-preferences.c
>         preferences.glade
> _______________________________________________
> gnucash-patches mailing list
> [hidden email]
> https://lists.gnucash.org/mailman/listinfo/gnucash-patches

_______________________________________________
gnucash-patches mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-patches
Reply | Threaded
Open this post in threaded view
|

Re: Convert the default currency preferences over to gconf.

Derek Atkins
Two comments.

1) Please use "diff -u" and not "diff" when sending in diffs.  It's
much easier
to read a unified diff.

2) You can just use "safe_strcmp()"

-derek

Quoting Didier Vidal <[hidden email]>:

> I had to make this patch locally to avoid a crash with gnucash:
>
> [vidal@oscar3 app-utils]$ cvs diff *.c
> Index: global-options.c
> ===================================================================
> RCS file: /home/cvs/cvsroot/gnucash/src/app-utils/global-options.c,v
> retrieving revision 1.6.4.4
> diff -r1.6.4.4 global-options.c
> 398c398
> <   if (strcmp(choice, "other") == 0) {
> ---
>>   if (choice && strcmp(choice, "other") == 0) {
> 421c421
> <   if (strcmp(choice, "other") == 0) {
> ---
>>   if (choice && strcmp(choice, "other") == 0) {
>
>
>
> Le sam 24/09/2005 à 22:28, David Hampton a écrit :
>> Log Message:
>> -----------
>> Convert the default currency preferences over to gconf.
>>
>> Tags:
>> ----
>> gnucash-gnome2-dev
>>
>> Modified Files:
>> --------------
>>     gnucash:
>>         ChangeLog
>>     gnucash/src/app-utils:
>>         global-options.c
>>         prefs.scm
>>     gnucash/src/gnome/schemas:
>>         apps_gnucash_general.schemas
>>     gnucash/src/gnome-utils:
>>         dialog-preferences.c
>>         preferences.glade
>> _______________________________________________
>> gnucash-patches mailing list
>> [hidden email]
>> https://lists.gnucash.org/mailman/listinfo/gnucash-patches
>
> _______________________________________________
> gnucash-patches mailing list
> [hidden email]
> https://lists.gnucash.org/mailman/listinfo/gnucash-patches
>



--
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       [hidden email]                        PGP key available


_______________________________________________
gnucash-patches mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-patches
Reply | Threaded
Open this post in threaded view
|

Re: Convert the default currency preferences over to gconf.

David Hampton-2
In reply to this post by Didier Vidal
On Sun, 2005-09-25 at 13:38 +0200, Didier Vidal wrote:
> I had to make this patch locally to avoid a crash with gnucash:

Sorry about that.  I need to remember to delete my gconf database once
in a while to check for these issues.  Fix shortly.

David


_______________________________________________
gnucash-patches mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-patches