Backport proposal for "Attached file indicator"

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Backport proposal for "Attached file indicator"

Geert Janssens-4
Robert Fewell recently contributed work to the master branch to add a
visual indicator to transactions when a file/uri is attached, and some
further refinements in that area.

There is an enhancement request for this in bugzilla as well [1]

While our policy states new features should be added on the master
branch only, I'm considering backporting a minimal base part of Roberts
work to maint anyway. That is the indicator itself only. This is a
relatively well contained bit of gui code that's not too complicated to
review. I'm talking about commits 5bb53c044..5f75f106ee here. Robert
made more improvements, but this minimal set would greatly increase the
usefulness of the file association feature.

Any objections ?

Regards,

Geert

P.S. I asked for this on the bugreport as well, but didn't see any
responses. Probably my request got lost in the noise.


[1] https://bugzilla.gnome.org/show_bug.cgi?id=744790
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: Backport proposal for "Attached file indicator"

Christian Stimming-4
Good idea. No objections. Feel free to go ahead with useful back ports. Thanks!

Christian

> Am 13.09.2016 um 12:30 schrieb Geert Janssens <[hidden email]>:
>
> Robert Fewell recently contributed work to the master branch to add a
> visual indicator to transactions when a file/uri is attached, and some
> further refinements in that area.
>
> There is an enhancement request for this in bugzilla as well [1]
>
> While our policy states new features should be added on the master
> branch only, I'm considering backporting a minimal base part of Roberts
> work to maint anyway. That is the indicator itself only. This is a
> relatively well contained bit of gui code that's not too complicated to
> review. I'm talking about commits 5bb53c044..5f75f106ee here. Robert
> made more improvements, but this minimal set would greatly increase the
> usefulness of the file association feature.
>
> Any objections ?
>
> Regards,
>
> Geert
>
> P.S. I asked for this on the bugreport as well, but didn't see any
> responses. Probably my request got lost in the noise.
>
>
> [1] https://bugzilla.gnome.org/show_bug.cgi?id=744790
> _______________________________________________
> gnucash-devel mailing list
> [hidden email]
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel


_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: Backport proposal for "Attached file indicator"

Derek Atkins
In reply to this post by Geert Janssens-4
Geert,

Geert Janssens <[hidden email]> writes:

> Robert Fewell recently contributed work to the master branch to add a
> visual indicator to transactions when a file/uri is attached, and some
> further refinements in that area.
>
> There is an enhancement request for this in bugzilla as well [1]
>
> While our policy states new features should be added on the master
> branch only, I'm considering backporting a minimal base part of Roberts
> work to maint anyway. That is the indicator itself only. This is a
> relatively well contained bit of gui code that's not too complicated to
> review. I'm talking about commits 5bb53c044..5f75f106ee here. Robert
> made more improvements, but this minimal set would greatly increase the
> usefulness of the file association feature.

IMHO, useful features that are small, useful, and relatively self
contained (and don't affect lots of strings) are welcome to be
backported.

> Any objections ?

None from me.

> Regards,
>
> Geert
>
> P.S. I asked for this on the bugreport as well, but didn't see any
> responses. Probably my request got lost in the noise.
>
>
> [1] https://bugzilla.gnome.org/show_bug.cgi?id=744790

-derek

--
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       [hidden email]                        PGP key available
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: Backport proposal for "Attached file indicator"

John Ralls-2

> On Sep 13, 2016, at 7:37 AM, Derek Atkins <[hidden email]> wrote:
>
> Geert,
>
> Geert Janssens <[hidden email]> writes:
>
>> Robert Fewell recently contributed work to the master branch to add a
>> visual indicator to transactions when a file/uri is attached, and some
>> further refinements in that area.
>>
>> There is an enhancement request for this in bugzilla as well [1]
>>
>> While our policy states new features should be added on the master
>> branch only, I'm considering backporting a minimal base part of Roberts
>> work to maint anyway. That is the indicator itself only. This is a
>> relatively well contained bit of gui code that's not too complicated to
>> review. I'm talking about commits 5bb53c044..5f75f106ee here. Robert
>> made more improvements, but this minimal set would greatly increase the
>> usefulness of the file association feature.
>
> IMHO, useful features that are small, useful, and relatively self
> contained (and don't affect lots of strings) are welcome to be
> backported.
>
>> Any objections ?
>
> None from me.

I agree.

Regards,
John Ralls

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: Backport proposal for "Attached file indicator"

Alex Aycinena-2
In reply to this post by Geert Janssens-4
>
>
> ---------- Forwarded message ----------
> From: John Ralls <[hidden email]>
> To: Derek Atkins <[hidden email]>
> Cc: [hidden email]
> Date: Tue, 13 Sep 2016 08:19:45 -0700
> Subject: Re: Backport proposal for "Attached file indicator"
>
> > On Sep 13, 2016, at 7:37 AM, Derek Atkins <[hidden email]> wrote:
> >
> > Geert,
> >
> > Geert Janssens <[hidden email]> writes:
> >
> >> Robert Fewell recently contributed work to the master branch to add a
> >> visual indicator to transactions when a file/uri is attached, and some
> >> further refinements in that area.
> >>
> >> There is an enhancement request for this in bugzilla as well [1]
> >>
> >> While our policy states new features should be added on the master
> >> branch only, I'm considering backporting a minimal base part of Roberts
> >> work to maint anyway. That is the indicator itself only. This is a
> >> relatively well contained bit of gui code that's not too complicated to
> >> review. I'm talking about commits 5bb53c044..5f75f106ee here. Robert
> >> made more improvements, but this minimal set would greatly increase the
> >> usefulness of the file association feature.
> >
> > IMHO, useful features that are small, useful, and relatively self
> > contained (and don't affect lots of strings) are welcome to be
> > backported.
> >
> >> Any objections ?
> >
> > None from me.
>
> I agree.
>
> Regards,
> John Ralls
>
>
>
So do I,

Alex
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel