Are patches to 1.8 useful?

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Are patches to 1.8 useful?

Mike Alexander
I've been using gnucash to keep track of my finances for the last year
or so.  Since I wanted a reliable program (I got tired of Quicken
crashing) I've been using version 1.8.

During that time I've made a number of changes to gnucash to fix bugs
and improve it in various ways.  Are you interested in patches for
these changes?  Most of them are small changes that might still be
relevant to the 1.9/2.0 code stream.  If the 1.8 code stream is so old
and out of date that you don't care about changes to it, I won't bother
generating patches.  On the other hand if the patches would be useful
I'm happy to generate them.

The changes affect things like handling multiple currencies, using
consistent prices in reports, building in a separate directory from the
source and running from that directory without installing gnucash,
speeding up loading of large files, and a few other things.

--
Mike Alexander
Ann Arbor, MI

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: Are patches to 1.8 useful?

Christian Stimming
Hi,

thanks for reporting this. As you've guessed, the development of the
1.8.x branch has completely stopped, so we won't apply any patches to
1.8 anywhere in SVN/CVS.

However, since you said some things might be relevant to HEAD/1.9/2.0 as
well, it might be a good idea to send it anyway, not the least so that
other people who need improvements in 1.8 might dig this up from the
archive. Depends on how much effort you are willing to spend.

As for potential 1.9/2.0 improvements: These are tracked issue-by-issue
in bugzilla, http://bugzilla.gnome.org/enter_bug.cgi?product=GnuCash so
actually the most helpful thing for us would be to open *one bugzilla
report per issue*, where the solved problem/enhancement is described and
the patch is attached (attachments can be uploaded after you initially
committed the bugreport). This way you will have the guarantee that all
potential improvements are reviewed, commented upon, and (if relevant to
1.9/SVN-HEAD) applied to SVN -- but of course we cannot tell beforehand
whether some of these bugzilla reports might not be closed as
"irrelevant to 1.9/WONTFIX".

Entering these into bugzilla, one issue per report, would definitely be
the most helpful contribution for us. But if you don't want to spend
that much effort on this, you can still consider sending everything in
one batch here, but on the mailing list non-trivial patches tend to get
forgotten sometimes. On the other hand in bugzilla they surely won't be
forgotten.

Thank you for any contribution here.

Regards

Christian

Mike Alexander schrieb:

> I've been using gnucash to keep track of my finances for the last year
> or so.  Since I wanted a reliable program (I got tired of Quicken
> crashing) I've been using version 1.8.
>
> During that time I've made a number of changes to gnucash to fix bugs
> and improve it in various ways.  Are you interested in patches for these
> changes?  Most of them are small changes that might still be relevant to
> the 1.9/2.0 code stream.  If the 1.8 code stream is so old and out of
> date that you don't care about changes to it, I won't bother generating
> patches.  On the other hand if the patches would be useful I'm happy to
> generate them.
>
> The changes affect things like handling multiple currencies, using
> consistent prices in reports, building in a separate directory from the
> source and running from that directory without installing gnucash,
> speeding up loading of large files, and a few other things.
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Reply | Threaded
Open this post in threaded view
|

Re: Are patches to 1.8 useful?

Tim Wunder (Lists)
In reply to this post by Mike Alexander
On Wednesday 18 January 2006 4:29 am, someone claiming to be Mike Alexander
wrote:

> I've been using gnucash to keep track of my finances for the last year
> or so.  Since I wanted a reliable program (I got tired of Quicken
> crashing) I've been using version 1.8.
>
> During that time I've made a number of changes to gnucash to fix bugs
> and improve it in various ways.  Are you interested in patches for
> these changes?  Most of them are small changes that might still be
> relevant to the 1.9/2.0 code stream.  If the 1.8 code stream is so old
> and out of date that you don't care about changes to it, I won't bother
> generating patches.  On the other hand if the patches would be useful
> I'm happy to generate them.
>
> The changes affect things like handling multiple currencies, using
> consistent prices in reports, building in a separate directory from the
> source and running from that directory without installing gnucash,
> speeding up loading of large files, and a few other things.
There is an old enhancement request in bugzilla regarding loading of files:
http://bugzilla.gnome.org/show_bug.cgi?id=103501
The code pertinent to that fix might be useful as an attachement to that bug.

You may also want to check bugzilla for bugs relevant to your other fixes
prior to any attempt at creating new bug reports (if you choose to do so).

Thanks!

Tim

_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

attachment0 (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Are patches to 1.8 useful?

Derek Atkins
In reply to this post by Christian Stimming
Just adding my $0.02 --

If you take the effort to up-port your changes to SVN they will
definitely be applied quicker than if you do not.  (Speaking for
myself, I'm much more willing to apply a patch that only requires me
to audit it, run 'patch', and then commit -- if I have to hand apply a
large patch I'm much more likely to put it on hold and go get a
sandwich and do something else).   ;)

>From the description it certainly sounds like some of your changes
are relevant, but again it would help if you tested SVN first to
make sure before going through the effort to create the bugzilla
reports.

Thanks!

-derek

Christian Stimming <[hidden email]> writes:

> Hi,
>
> thanks for reporting this. As you've guessed, the development of the
> 1.8.x branch has completely stopped, so we won't apply any patches to
> 1.8 anywhere in SVN/CVS.
>
> However, since you said some things might be relevant to HEAD/1.9/2.0 as
> well, it might be a good idea to send it anyway, not the least so that
> other people who need improvements in 1.8 might dig this up from the
> archive. Depends on how much effort you are willing to spend.
>
> As for potential 1.9/2.0 improvements: These are tracked issue-by-issue
> in bugzilla, http://bugzilla.gnome.org/enter_bug.cgi?product=GnuCash so
> actually the most helpful thing for us would be to open *one bugzilla
> report per issue*, where the solved problem/enhancement is described and
> the patch is attached (attachments can be uploaded after you initially
> committed the bugreport). This way you will have the guarantee that all
> potential improvements are reviewed, commented upon, and (if relevant to
> 1.9/SVN-HEAD) applied to SVN -- but of course we cannot tell beforehand
> whether some of these bugzilla reports might not be closed as
> "irrelevant to 1.9/WONTFIX".
>
> Entering these into bugzilla, one issue per report, would definitely be
> the most helpful contribution for us. But if you don't want to spend
> that much effort on this, you can still consider sending everything in
> one batch here, but on the mailing list non-trivial patches tend to get
> forgotten sometimes. On the other hand in bugzilla they surely won't be
> forgotten.
>
> Thank you for any contribution here.
>
> Regards
>
> Christian
>
> Mike Alexander schrieb:
>> I've been using gnucash to keep track of my finances for the last
>> year or so.  Since I wanted a reliable program (I got tired of
>> Quicken crashing) I've been using version 1.8.
>> During that time I've made a number of changes to gnucash to fix
>> bugs and improve it in various ways.  Are you interested in patches
>> for these changes?  Most of them are small changes that might still
>> be relevant to the 1.9/2.0 code stream.  If the 1.8 code stream is
>> so old and out of date that you don't care about changes to it, I
>> won't bother generating patches.  On the other hand if the patches
>> would be useful I'm happy to generate them.
>> The changes affect things like handling multiple currencies, using
>> consistent prices in reports, building in a separate directory from
>> the source and running from that directory without installing
>> gnucash, speeding up loading of large files, and a few other things.
> _______________________________________________
> gnucash-devel mailing list
> [hidden email]
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>
>

--
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       [hidden email]                        PGP key available
_______________________________________________
gnucash-devel mailing list
[hidden email]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel